Project

General

Profile

Emulator Issues #10044

Returning to the System Menu from HBC is broken

Added by leoetlino over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-1802
Fixed in:
5.0-2164

Description

Game Name?

The Homebrew Channel (open source version)

What's the problem? Describe what went wrong.

The HBC has an option to return to the system menu. On older versions, it works just fine. But now it just hangs on a black screen; enabling panic handlers reveals that there are invalid reads in a loop.

What steps will reproduce the problem?

  1. Install the HBC and a System Menu (tested it with 4.1 personally).
  2. Launch the HBC.
  3. Press HOME on the Wii remote, then select Exit to System Menu.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

git bisect start
# bad: [dd9e6760c456f104ff250e5095215a4e8cb7b310] Merge pull request #4659 from leoetlino/chunkfile-set
git bisect bad dd9e6760c456f104ff250e5095215a4e8cb7b310
[...]
# good: [66ea9f5cc18ca6beb87ddd7f7a291d96669ad653] DiscIO: Add GetRegion function and Region enum
git bisect good 66ea9f5cc18ca6beb87ddd7f7a291d96669ad653
# first bad commit: [f85266df20bf81777a422dcd71d725f8cf712cd9] SConfig: Replace bNTSC with m_region

PAL60 doesn't affect anything.

History

#1 Updated by JMC4789 over 3 years ago

who do i blame this on. You didn't link to a PR and I'm lazy.

#2 Updated by JMC4789 over 3 years ago

  • Status changed from New to Accepted
  • Assignee set to JosJuice
  • Priority changed from Normal to High
  • Regression changed from No to Yes

#3 Updated by JosJuice over 3 years ago

  • Priority changed from High to Normal
  • Regression start set to 5.0-1802

It seems like this only happens when launching HBC directly, not when launching it through the system menu. (But I haven't been able to confirm it, because Dolphin crashes when I directly boot the WAD in a recent Dolphin version.) My guess is that the commit affected the handling of unknown regions in some way that HBC doesn't like, because the open source version of HBC uses the game ID OHBC, and C isn't a region we recognize.

Decreasing the priority to Normal because launching the open source version of HBC directly from a WAD isn't all that important.

#4 Updated by JMC4789 over 3 years ago

  • Status changed from Accepted to Fixed

Also available in: Atom PDF