Project

General

Profile

Actions

Emulator Issues #10146

closed

Latest master wont build due to "error: expected unqualified-id before numeric constant"

Added by insanemal over 7 years ago. Updated over 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Linux
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-2851

Description

Latest git tree doesn't build on linux. Details as follows:

[ 92%] Building CXX object Source/Core/VideoBackends/Vulkan/CMakeFiles/videovulkan.dir/RasterFont.cpp.o
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/6.3.1/include-fixed/limits.h:168:0,
from /usr/lib/gcc/x86_64-pc-linux-gnu/6.3.1/include-fixed/syslimits.h:7,
from /usr/lib/gcc/x86_64-pc-linux-gnu/6.3.1/include-fixed/limits.h:34,
from /home/malcolm/dolphin/Source/Core/Common/Common.h:63,
from /home/malcolm/dolphin/Source/Core/Common/BitField.h:37,
from /home/malcolm/dolphin/Source/Core/VideoBackends/Vulkan/Constants.h:9,
from /home/malcolm/dolphin/Source/Core/VideoBackends/Vulkan/RasterFont.h:12,
from /home/malcolm/dolphin/Source/Core/VideoBackends/Vulkan/RasterFont.cpp:5:
/home/malcolm/dolphin/Source/Core/VideoBackends/Vulkan/RasterFont.cpp:20:15: error: expected unqualified-id before numeric constant
constexpr int CHAR_WIDTH = 8;

It looks like its the same issue as https://github.com/dolphin-emu/dolphin/pull/4496 but with Vulkan not OGL

Thanks in advance

Actions #1

Updated by insanemal over 7 years ago

sed -i '/s/CHAR_/VCHAR_' Source/Core/VideoBackends/Vulkan/CMakeFiles/videovulkan.dir/RasterFont.cpp

Gets it building V was chosen because Vulkan. And because the fix for the OGL driver in the Linked pull request simply changed CHAR into CHARACTER so I assumed, rightly or wrongly, a similar fix, that didn't collide, would also resolve this...

Actions #2

Updated by JosJuice over 7 years ago

This PR should fix it, but I haven't been able to verify that it actually fixes the problem, because I'm on Windows. https://github.com/dolphin-emu/dolphin/pull/5065

Actions #3

Updated by JosJuice over 7 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-2851
  • Operating system Linux added
  • Operating system deleted (N/A)
Actions

Also available in: Atom PDF