Emulator Issues #10208
open
Do not unload things when the Stop button is pressed
0%
Description
Game Name?
All
Game ID? (right click the game in the game list, properties, info tab)
N/A.
MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)
N/A
What's the problem? Describe what went wrong.
Since the graceful shutdown addition, pressing the Stop button acts like the POWER button.
However, there are cases where pressing the POWER/RESET button won't lead to a shutdown.
So clearing watches, breakpoints, symbols & cie, shouldn't be done that early.
Furthermore, unpausing the emulator while in debug mode prevents to debug, especially after pressing the POWER button in a case where it doesn't lead to a Wii shutdown.
What steps will reproduce the problem?
Press the STOP button or shortcuts for POWER and RESET buttons.
Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?
Since Dolphin 5.0-1532 I guess.
What are your PC specifications? (CPU, GPU, Operating System, more)
Windows 7 Profesionnal (x64) - Service Pack 1
Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz 2.40 GHz
Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
Updated by leoetlino over 7 years ago
Wait, we clear watches, etc. when stopping and resetting? That's definitely an oversight. By the way, the commit you linked only affects netplay/movie (as described).
Unpausing after a shutdown is pretty much required for good UX, though, and I can't see a reason to not unpause in order to shut down, when the user wants to shut down, even in debug mode.
Updated by sepalani over 7 years ago
As far as I remember, it also affected the debugging part since you moved down the shutdown handling after clearing breakpoints and stuff in FrameTools.cpp.
By the way, the lambda user in Dolphin probably want to shutdown after pressing that Stop button but what if someone debugging doesn't want to "shutdown" and instead wants to trigger a POWER/RESET button input. That's slightly different and that's my case =vP.
Regardless, triggering these buttons doesn't mean that the process running will "shutdown" (the Wii properly) since it can hook its own callbacks to handle them and then call SYS_ResetSystem or STM_Shutdown* later... or not.
Updated by pokechu22 almost 3 years ago
This doesn't seem to be an issue anymore. (Not sure when it was fixed, but maybe it was with DolphinQt?)