Project

General

Profile

Actions

Emulator Issues #10244

closed

ES_DeleteTicket's implementation is completely wrong

Added by leoetlino almost 7 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-3640

Description

There's not a single thing done right in its implementation.

  • It should take a ticket view, not a title ID.
  • It's missing a lot of checks.
  • It's not deleting tickets properly.
  • It's not deleting only the ticket it needs to delete.
  • It should not return -1017 when the ticket doesn't exist.
  • It's not returning the proper error code when a read/write fails.
  • It's not cleaning up the ticket directory if there is no file left in it.
Actions #1

Updated by Helios almost 7 years ago

  • Status changed from New to Accepted
  • Assignee set to leoetlino
Actions #2

Updated by leoetlino almost 7 years ago

  • Status changed from Accepted to Fixed
  • Fixed in set to 5.0-3640
Actions

Also available in: Atom PDF