Emulator Issues #10366
closedFeature regression: Can't use PNG banners for volumes
0%
Description
When the ability to use PNG banners was added to DolphinWX, it intentionally worked for both DOL/ELF files and for volumes. A removal of the ability to use PNG banners for volumes was included as part of https://github.com/dolphin-emu/dolphin/pull/5659/commits/f16599f4a842c51412a4d890cdaccf4f0b618872. It seems like it could've been an accident since there still is a comment in ISOFile.cpp saying that PNG banners can be used with volumes, but at the same time, supporting this does make the game list performance worse, so it could've been intentional...
I've marked this issue report as Current, not because I'm saying it has to be fixed before the next stable release no matter what, but because we should either fix it or make a proper decision to drop this feature. (That the removal was in a self-merged PR with no LGTMs that didn't point out the removal in any commit description or PR comment meant that there was essentially no input on whether the removal was fine.) So I'd like to do it this way: If others agree to drop this feature, close this issue. Otherwise, this issue remains open as a Current blocker.
Updated by JosJuice almost 7 years ago
- Is duplicate of Emulator Issues #10938: Feature regression: Custom PNG banners added
Updated by JosJuice almost 7 years ago
- Status changed from Accepted to Duplicate