https://bugs.dolphin-emu.org/https://bugs.dolphin-emu.org/favicon.ico?12017-08-25T01:43:11ZDolphin bug trackerEmulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304012017-08-25T01:43:11ZJMC4789JMC4789@gmail.com
<ul></ul><p>meh</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304022017-08-25T01:46:07Zdelrothdelroth@gmail.com
<ul></ul><p>Yeah... I'm going to say you're testing this wrong, because this PR literally has no way of impacting code paths outside of WFS, AFAICT.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304032017-08-25T01:47:12ZHelios
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Questionable</i></li></ul> Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304042017-08-25T01:52:56Zryanebola16
<ul></ul><p>I redownloaded the following PRs and got the same results:<br>
<strong>5.0-5291: SLOW</strong><br>
5.0-5264: FINE</p>
<p>Can someone try to reproduce the problem?</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304052017-08-25T02:27:10ZJMC4789JMC4789@gmail.com
<ul></ul><p>I followed your exact steps and performance is exactly the same, 120 - 140 fps on master, 120-140 fps on 5.0-5264</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304062017-08-25T02:44:36Zryanebola16
<ul><li><strong>File</strong> <a href="/attachments/6291">WFS.PNG</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6291/WFS.PNG">WFS.PNG</a> added</li></ul><p>I'll add this image to show I'm not going insane.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304072017-08-25T02:50:10ZJMC4789JMC4789@gmail.com
<ul></ul><p>If you can, download visual studio, compile the build before/after WFS, and do the performance analysis, and show us the different hot paths. That'll tell us what is making it slower for you.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304082017-08-25T02:50:44ZJMC4789JMC4789@gmail.com
<ul></ul><p>There's a guide on how to compile on the github page, and I'll try to provide any extra assistance I can.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304092017-08-25T03:05:13ZJMC4789JMC4789@gmail.com
<ul></ul><p>Have you tried running them separately? It seems as though Windows schedules the selected app to get more performance considerations than background ones. In you screenshot, the old build is selected, meaning it would run significantly faster.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304102017-08-25T03:07:34Zryanebola16
<ul></ul><p>Oops, I forgot to mention that I photoshoped that image. Each build was run separately. I'm looking into performance profiling now.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304112017-08-25T03:37:37Zryanebola16
<ul><li><strong>File</strong> <a href="/attachments/6295">PerfPro.part1.rar</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6295/PerfPro.part1.rar">PerfPro.part1.rar</a> added</li><li><strong>File</strong> <a href="/attachments/6296">PerfPro.part2.rar</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6296/PerfPro.part2.rar">PerfPro.part2.rar</a> added</li><li><strong>File</strong> <a href="/attachments/6297">PerfPro.part3.rar</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6297/PerfPro.part3.rar">PerfPro.part3.rar</a> added</li></ul><p>I've added the Performance Profiler output for my two branches: PREWFS and WFS. I included an image of the split to make sure I did it right.</p>
<p>Stupid 5MB limit...</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304122017-08-25T03:40:23Zryanebola16
<ul></ul><p>And for both profiler output runs, I completed a one stock match mario vs mario on final destination then closed Dolphin.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304152017-08-25T06:42:14ZJMC4789JMC4789@gmail.com
<ul></ul><p>Another thing you can do is bisect to commits inside of WFS merge if you're compiling yourself, which could be super useful!</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304212017-08-25T12:47:20Zryanebola16
<ul></ul><p>Unfortunately the commits appear to be dependent upon each other. I tried reverting a few of them individually but each one would crash the emulator.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304222017-08-25T12:48:39ZJMC4789JMC4789@gmail.com
<ul></ul><p>Fair enough, thank you for the attempt!</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304232017-08-25T12:54:42ZJMC4789JMC4789@gmail.com
<ul></ul><p>Checked your performance logs, the slowdown appears to be in the D3D Async compiler... can you try OpenGL/Vulkan?</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304242017-08-25T13:24:56Zryanebola16
<ul></ul><p>I could reproduce the problem on DX11 and OGL. Could not reproduce on Vulkan.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304252017-08-25T13:27:13ZJMC4789JMC4789@gmail.com
<ul></ul><p>It sounds like this is completely unrelated to WFS and more likely something going on with your computer not liking the new exes.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304262017-08-25T14:14:34Zryanebola16
<ul><li><strong>File</strong> <a href="/attachments/6298">RevHist1.PNG</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6298/RevHist1.PNG">RevHist1.PNG</a> added</li></ul><p>Building without a debugger helped me get around some access violations.</p>
<p>For the WFS Updates pull request merge:<br>
Reverting the latest commits through WFSI: Fix the TMD size check did not fix the problem.</p>
<p>I then reverted "WFSI: Implement patch install" finalization and the problem is no longer present.</p>
<p>See RevHist1.png for my history of changes.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304272017-08-25T14:20:54ZJMC4789JMC4789@gmail.com
<ul></ul><p>So, I relooked at your performance graph, the D3D thing had to do with ubershaders compiling. I have no idea why Vulkan isn't affected, that commit shouldn't cause a slowdown.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304282017-08-25T14:26:21Zryanebola16
<ul></ul><p>I had Ubershaders set to hybrid for all of the tests I have done for this issue. I set Ubershaders to Disabled and retested. It did not make a difference.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304292017-08-25T14:26:53ZJMC4789JMC4789@gmail.com
<ul></ul><p>Like I said, it was just throwing it off, I filtered it and now they're mostly identical.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304302017-08-25T14:30:26ZJMC4789JMC4789@gmail.com
<ul></ul><p>Can you put a breakpoint on File::CopyDir and see if it ever gets hit while you're playing.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304312017-08-25T14:31:34ZJosJuice
<ul></ul><p>For the reference, File::CopyDir is in Source/Core/Common/FileUtil.cpp.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304322017-08-25T15:02:54Zryanebola16
<ul><li><strong>File</strong> <a href="/attachments/6299">CopyDir.PNG</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6299/CopyDir.PNG">CopyDir.PNG</a> added</li></ul><p>Am I doing it right?</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304332017-08-25T15:07:13ZJosJuice
<ul></ul><p>Yes, the breakpoint has been set up correctly, and it has also been triggered. (Though it seems like it got triggered when you're starting Dolphin, and we're only interested in if it gets triggered when running the game.)</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304342017-08-25T15:15:27Zryanebola16
<ul></ul><p>I needed to silence access violations to be able to use the debugger but that breakpoint was not triggered during gameplay.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304352017-08-25T15:59:24Zsepalanisepalani@hotmail.fr
<ul></ul><p>Is your issue fixed if you replace this code in FileUtil.cpp line 571</p>
<pre><code> else
{
Rename(source, dest);
}
</code></pre>
<p>with:</p>
<pre><code> else if (destructive)
{
Rename(source, dest);
}
</code></pre> Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304362017-08-25T16:23:20Zryanebola16
<ul></ul><p>Oh wow that does fix it! (tested all video backends, re-enabled codes, and re-enabled hybrid Ubershaders)<br>
Thanks!</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304372017-08-25T17:13:24ZJosJuice
<ul><li><strong>Status</strong> changed from <i>Questionable</i> to <i>Fix pending</i></li><li><strong>Milestone</strong> set to <i>Current</i></li><li><strong>Regression</strong> changed from <i>No</i> to <i>Yes</i></li><li><strong>Regression start</strong> set to <i>5.0-5291</i></li></ul><p><a href="https://github.com/dolphin-emu/dolphin/pull/5980" class="external">https://github.com/dolphin-emu/dolphin/pull/5980</a></p>
<p>I don't know how that change fixes the issue, but it's a change that makes sense, so...</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304382017-08-25T17:37:59ZJosJuice
<ul><li><strong>Status</strong> changed from <i>Fix pending</i> to <i>Fixed</i></li><li><strong>Fixed in</strong> set to <i>5.0-5314</i></li></ul><p><a href="https://dolphin-emu.org/download/dev/a861c5772d3a36d55a7bef1dc7481f620460ff07/" class="external">https://dolphin-emu.org/download/dev/a861c5772d3a36d55a7bef1dc7481f620460ff07/</a></p>
<p>Thanks for all the help with tracking the issue down.</p>
Emulator - Emulator Issues #10499: Major slowdown due to "WFS updates"https://bugs.dolphin-emu.org/issues/10499?journal_id=7304392017-08-25T17:39:03ZHelios
<ul></ul><p>(╯°□°)╯︵ ┻━┻</p>