Project

General

Profile

Actions

Emulator Issues #10513

closed

Star Fox Adventures shadow graphical glitches

Added by killerloader over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-5417

Description

Game Name?

Star Fox Adventures

Game ID? (right click the game in the game list, properties, info tab)

GSAP01

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

c1cc9f1a6540e73223fab48450efbfd6

What's the problem? Describe what went wrong.

When running the game with DX11, shadows sometimes get corrupted (or copied) from other entities.

What steps will reproduce the problem?

  • Run the game in a Direct3D variant on any version of dolphin.
  • Move your character next to the Arwing in thorntail hollow (It happens almost anywhere when you can see the shadows of other entities)
  • Get a corrupt shadow.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, i tried it in 5.0-5343

Is the issue present in the latest stable version?

Yes, 5.0

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

Couldn't find a working version.

Tested:
4.0-3543 (Could reproduce in Direct3D)
3.5-1704 (Could reproduce in Direct3D9 and Direct3D11)
(I feel like this is as far back as necessary?)

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

As you can see with the shadow of starfox, there is a "sharpclaw" (The enemies in this game) shadow mixed in with the player's shadow.
The image explains itself, Star Fox is not meant to have a garbled mess for a shadow.

What are your PC specifications? (CPU, GPU, Operating System, more)

Windows 10
i7-4790k @ 4.6GHz
Nvida GTX 1070

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

With all the versions i tested, i could only ever get the bug to occur with a Direct3D graphics backend.

When testing, for every version of dolphin i used, i changed these settings:

  • Dual Core Off
  • Idle Skipping (For supported versions) off
  • Safe Texture Cache
  • All other hacks unticked
  • Real XFB
  • Native internal resolution, no AA, no anisotropic filtering
  • Ubershaders disabled.
  • All other Enhancements unticked
  • Direct3D variants used.
  • All advanced options unticked

I tried a few other combinations of options such as: (Also because i wasn't originally playing with the above settings when i kept noticing the bug)

  • Having ubershaders enabled.
  • Disabled XFB
  • Dual core enabled
  • 3X IR
  • 16x AF
  • Scaled EFB (And probably more) Always resulting in the bug in D3D

The old issue report for this was marked as "fixed" with no explanation 5 years ago.
(https://bugs.dolphin-emu.org/issues/2879)

The wiki page for Star Fox Adventures still shows the issue, but does not link an issue page, and i could not find an open issue for it.

I've uploaded a 3 frame FIFO log here:
https://mega.nz/#!UJpHUTiS!bJjqPmU5iiklhlsTuXpK2uEEN0_bkzuwAer85pjmpto

Tell me if any more information is required!


Files

Starfox Adventures shadow bug.png (826 KB) Starfox Adventures shadow bug.png killerloader, 09/02/2017 10:25 AM
Actions #1

Updated by JMC4789 over 6 years ago

  • Assignee set to Stenzek

Can you look at the fifolog, stenzek.

Actions #2

Updated by killerloader over 6 years ago

Just re-uploaded the FIFO log:
https://mega.nz/#!NF5iUBqI!_dIIIXoPgzCVZhFeHhOTxb5dLEMpDEstcNaUeX7F_Bc

I did the log with EFB to texture, and real XFB without properly reading the guide, as those were my test conditions, so it was dud. Sorry about that!

Actions #3

Updated by Stenzek over 6 years ago

  • Status changed from New to Fix pending

Requires logic op support in the backend, and the approximation method used by D3D is wildly inaccurate.

I've implemented it in PR 6013, but there are still some open issues that need resolving (the uid bit): https://github.com/dolphin-emu/dolphin/pull/6013

Actions #4

Updated by JMC4789 over 6 years ago

WHAT?! This is a logic op issue?!!!

Actions #5

Updated by killerloader over 6 years ago

Nice! Fixed as far as i can tell.

Actions #6

Updated by killerloader over 6 years ago

Problem still exists when using ubershaders and DX11 (Can only really tell on exclusive)

Actions #7

Updated by Stenzek over 6 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-5417
Actions

Also available in: Atom PDF