Project

General

Profile

Emulator Issues #10600

Memcard Manager crashes with certain memory card layouts

Added by piltdownman almost 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

None (Dolphin UI issue)

Game ID? (right click the game in the game list, properties, info tab)

None (Dolphin UI issue)

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

None (Dolphin UI issue)

What's the problem? Describe what went wrong.

Certain memory card layouts cause the memory card manager to crash. This happened with a dump from a real 251 card (created using GCMM). A modified version of that image is attached which triggers the crash.

What steps will reproduce the problem?

  1. Unzip the attached file
  2. Launch Memcard Manager in Dolphin
  3. Try to open crash.USA.raw

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, this occurs in 5.0-5698.

Is the issue present in the latest stable version?

Yes, this occurs in 5.0 release.

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

N/A

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

N/A

What are your PC specifications? (CPU, GPU, Operating System, more)

Windows 7 64-bit

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Card image that triggers the issue is attached. If I'm reading the code correctly, I believe the problem is that GCMemcard::ReadAnimRGBA8 doesn't actually look at the block layout; it just blindly increments animData. If the block layout is non-contiguous, it can increment the pointer into an incorrect block or (in this case) past the end of allocated memory.

crash.zip (21.7 KB) crash.zip piltdownman, 10/22/2017 10:10 PM

Related issues

Related to Emulator - Emulator Issues #11820: Memory Card Manager may not correctly display game titles/comments if they're not in the first block of data.New

History

#1 Updated by JosJuice 3 months ago

  • Related to Emulator Issues #11820: Memory Card Manager may not correctly display game titles/comments if they're not in the first block of data. added

Also available in: Atom PDF