Project

General

Profile

Actions

Emulator Issues #10683

closed

Incorrect disassembly of fneg and fabs instructions

Added by NokiDoki over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-6022

Description

Game Name?

Super Mario Sunshine (PAL) (or most likely any other game, really)

Game ID? (right click the game in the game list, properties, info tab)

GMSP01

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

72c4860d8555d5e790628e348abc244d

What's the problem? Describe what went wrong.

Inside the disassembly tab of the debugger, fneg and fabs instructions always display respectively f1 and f8 as their second argument. The disassembler appears to be reading bits 21-25 of the instruction instead of bits 16-20. These instructions execute with the correct arguments, only the disassembly is wrong.

What steps will reproduce the problem?

  1. Launch Dolphin with the -d flag
  2. Start Super Mario Sunshine (PAL)
  3. Pause the emulation
  4. In the Code tab, browse to 80213e0c. “fabs f2, f8” is displayed, but browsing to the same address in the Memory tab shows FC400210 (fabs f2, f0)

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes. Dolphin 5.0-5991

Is the issue present in the latest stable version?

Yes. Dolphin 5.0

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

N/A

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

[Attach any fifologs if possible, write a description of fifologs and screenshots here to assist people unfamiliar with the game.]

What are your PC specifications? (CPU, GPU, Operating System, more)

Intel Core i7-7700HQ @ 2.8GHz, NVIDIA GeForce GTX 1060, Windows 10 Home x64

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Not much really, it happens on every fabs and fneg instruction (maybe others too, idk). Again, the displayed values match bits 21-25, which are fixed in these instructions’ codes, rather than the actual argument stored in bits 16-20.


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #10396: Debugger display error for fabs instructionDuplicate

Actions
Actions #1

Updated by Lioncash over 6 years ago

  • Status changed from New to Fix pending
  • Assignee set to Lioncash
Actions #2

Updated by JosJuice over 6 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-6022
Actions #3

Updated by JosJuice over 6 years ago

Actions

Also available in: Atom PDF