Project

General

Profile

Actions

Emulator Issues #10696

closed

Dolphin on Android fails to compile shader

Added by rogelioespinoza2328 over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-6033

Description

Im getting an error on games then they look like weird. I have attached some pictures. The last build i tested that worked well is 5.0-5971. thank you


Files

Screenshot_20171209-105545.png (224 KB) Screenshot_20171209-105545.png getting this error on games rogelioespinoza2328, 12/10/2017 07:01 PM
Screenshot_20171210-125453.png (740 KB) Screenshot_20171210-125453.png then some games look like this rogelioespinoza2328, 12/10/2017 07:01 PM
Actions #1

Updated by JMC4789 over 6 years ago

  • Status changed from New to Questionable

Please upload that bad_ps file listed in the error message.

Actions #2

Updated by rogelioespinoza2328 over 6 years ago

#version 320 es

#define FORCE_EARLY_Z layout(early_fragment_tests) in

#define ATTRIBUTE_LOCATION(x)
#define FRAGMENT_OUTPUT_LOCATION(x)
#define FRAGMENT_OUTPUT_LOCATION_INDEXED(x, y)
#define UBO_BINDING(packing, x) layout(packing, binding = x)
#define SAMPLER_BINDING(x) layout(binding = x)
#define SSBO_BINDING(x) layout(binding = x)

#define VARYING_LOCATION(x)

#extension GL_ANDROID_extension_pack_es31a : enable

precision highp float;
precision highp int;
precision highp sampler2DArray;
precision highp usamplerBuffer;
precision highp sampler2DMS;
precision highp image2DArray;
#define float2 vec2
#define float3 vec3
#define float4 vec4
#define uint2 uvec2
#define uint3 uvec3
#define uint4 uvec4
#define int2 ivec2
#define int3 ivec3
#define int4 ivec4
#define frac fract
#define lerp mix
SAMPLER_BINDING(9) uniform sampler2DArray samp9;
#define samp0 samp9
#define uv0 f_uv0
in vec3 uv0;
out vec4 ocol0;
void main(){
vec4 texcol = texture(samp0, uv0);
const float4 colmat[7] = {
float4(0.257000, 0.504000, 0.098000, 0.000000),
float4(0.257000, 0.504000, 0.098000, 0.000000),
float4(0.257000, 0.504000, 0.098000, 0.000000),
float4(0.257000, 0.504000, 0.098000, 0.000000),
float4(0.062745, 0.062745, 0.062745, 0.062745),
float4(15.937500, 15.937500, 15.937500, 255.000000),
float4(0.066667, 0.066667, 0.066667, 0.003922),
};
texcol = floor(texcol * colmat[5]) * colmat[6];
ocol0 = float4(dot(texcol, colmat[0]), dot(texcol, colmat[1]), dot(texcol, colmat[2]), dot(texcol, colmat[3])) + colmat[4];
}
ERROR: 0:49: '{' : Syntax error: syntax error
ERROR: 1 compilation errors. No code generated.

Actions #3

Updated by JMC4789 over 6 years ago

  • Status changed from Questionable to New

Thanks! Hopefully someone will take a look at that soon and we'll get you some answers.

Actions #4

Updated by JonnyH over 6 years ago

The shader compilation issue should be fixed by https://github.com/dolphin-emu/dolphin/pull/6252 - hopefully that will help with the visual corruption, but I can't test as I don't have NFS: Carbon available.

If you could test and let us know that will be useful - an APK containing this fix can be found at https://dl.dolphin-emu.org/prs/pr-6252-dolphin-latest.apk

Actions #5

Updated by rogelioespinoza2328 over 6 years ago

Yes it's fixed. 👍

Actions #6

Updated by Helios over 6 years ago

  • Subject changed from Android emulator to Dolphin on Android fails to compile shader
  • Status changed from New to Fix pending
  • Regression changed from No to Yes
Actions #7

Updated by rogelioespinoza2328 over 6 years ago

hi, the latest build dolphin 5.0-6031 has that weird error. Maybe they didn't pulled/merged correctly. FYI
thanks

Actions #8

Updated by JosJuice over 6 years ago

The page at https://github.com/dolphin-emu/dolphin/pull/6252 tells you whether the change has been merged or not. Right now, it hasn't been merged. So you'll have to wait a little before the fix is available in master.

Actions #9

Updated by JosJuice over 6 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-6033
Actions

Also available in: Atom PDF