Emulator Issues #10775
closed
Unifiy games with multiple game INIs into one INI
0%
Description
Game Name?
Super Smash Bros. Melee
Game ID? (right click the game in the game list, properties, info tab)
GALE01
MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)
16c7b2acdba15f1f82b3fe83d53f8b4b
What's the problem? Describe what went wrong.
Let me know if I should split any of the following information into separate issues.
The multiple INIs are confusing. And game property's "Edit Config" and "Show Defaults" buttons are broken.
Edit Config: Displays a blank file
Show Defaults: The default INIs of this game are GAL.ini, GALE01r0.ini, GALE01r1.ini, and GALE01r2.ini. Pressing the button opens GAL.ini and GALE01r2.ini.
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
5.0-6164
What are your PC specifications? (CPU, GPU, Operating System, more)
Win 10 Pro x64
Intel Core i7-4702MQ CPU @2.20GHz
GeForce GT 750M
GeForce Game Ready Driver 390.65
Updated by JosJuice over 6 years ago
- Status changed from New to Invalid
We've already unified pretty much all the INIs that can be unified. GALE01r0.ini, GALE01r1.ini and GALE01r2.ini contain cheat codes which are only compatible with one version of the game, so we can't put the contents of them into GAL.ini.
Based on your description of the behavior of the two buttons, they're working as intended (though maybe it's confusing for the user).
Updated by ryanebola16 over 6 years ago
Ok that explains how "Show Defaults" works and makes sense.
But why does "Edit Config" open a blank file of GALE01.ini? That name doesn't match any INI.
Updated by JosJuice over 6 years ago
Because it always opens a six-letter INI. It's based on the game ID only, not on which default INIs exist for the game.
Updated by ryanebola16 over 6 years ago
Then what is the purpose of "Edit Config"? The tooltip is "This will let you manually edit the INI config file." I would assume that it should open an INI for editing and not be blank.
Updated by JosJuice over 6 years ago
It lets you edit the user config, which is separate from the default config. (The default config is never supposed to be edited directly.) If you haven't added anything to the user config before, it's expected that the user INI file will be blank when you open it.
Updated by ryanebola16 over 6 years ago
Oh that is unclear. Should I update the tooltip to "This will let you manually edit the INI user config file"?
Updated by JosJuice over 6 years ago
While that isn't worse, I'm not sure how much it would help the user understand.
Updated by ryanebola16 over 6 years ago
Sidetrack, The tooltip of "Show Defaults" states "Opens the default (read-only) configuration for this game in an external text editor." Changes to the file can be saved in an external text editor so it's not read-only.
How about this idea then?
"Edit Config" tooltip: "This will let you manually edit the INI user config file. Changes should be made to the user config and not the default config."
"Show Defaults" tooltip: "Opens the default configuration for this game in an external text editor. Changes should be made to the user config and not the default config."
Also, please rename this issue to "Improve "Edit Config" and "Show Defaults"'s tooltip"
Updated by ryanebola16 over 6 years ago
Actually I should unify the language further:
"Edit Config" tooltip: "This will let you manually edit the INI user config file for this game. Changes should be made to the user config and not the default config."
"Show Defaults" tooltip: "This will let you view the INI default config file for this game. Changes should be made to the user config and not the default config."
Also, please rename this issue to "Improve "Edit Config" and "Show Defaults"'s tooltip"
Updated by JosJuice over 6 years ago
Sorry, but that's not really the kind of thing that we track here at the issue tracker, so I'm not going to rename and reopen this issue. If you want to change the text, you should make a PR.
Updated by ryanebola16 over 6 years ago
There was definitely a problem with those buttons but I needed to open this issue to make sure I understood what was actually going on. PR opened with some further tweaks: https://github.com/dolphin-emu/dolphin/pull/6299
Thanks!