Emulator Issues #10897
closed
Android: user game-specific settings overrides improperly handle DOL and ELF
0%
Description
What's the problem? Describe what went wrong.
On Android, DOL and ELF user game-specific settings overrides will be improperly named.
What steps will reproduce the problem?
- Create a user game-specific settings overrides for a DOL or ELF via Dolphin's UI
- Observe it isn't applied since it is improperly named.
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
5.0-6346
Is the issue present in the latest stable version?
No, 5.0
If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
5.0-6341 introduced Android: Implement user game-specific settings overrides
What are your PC specifications? (CPU, GPU, Operating System, more)
Win 10 Pro x64
Intel Core i7-4702MQ CPU @2.20GHz
GeForce GT 750M
2x 8GB Hynix 1600MHz
GeForce Game Ready Driver 390.77
Updated by merauder75 over 6 years ago
It sets the name based on whatever the frontend passes it as the game ID.
Updated by JosJuice over 6 years ago
- Status changed from New to Accepted
- Easy changed from No to Yes
- Operating system Android added
- Operating system deleted (
N/A)
While I haven't tested this myself, it sounds like a valid issue. It's possible to make a game INI apply to DOL/ELF files by naming it 00000000.ini, but it would probably be better to not let people edit game INIs for DOLs/ELFs in the GUI since you otherwise would get the confusing behavior of editing the settings for all DOLs/ELFs instead of just the one you selected.
Updated by ryanebola16 over 6 years ago
I was in the middle of typing the same suggestion JosJuice made but he beat me to it. I agree.
Updated by merauder75 over 6 years ago
Okay, I'll work on implementing that, simply by checking if the game is in DOL/ELF format and throwing up a message stating game-specific overrides aren't available for it.
Updated by JosJuice over 6 years ago
I would suggest not showing the option of editing per-game settings for DOLs/ELFs rather than showing a message if you select the option, since that's how we do it on PC. (Or is it not in a menu?)
Updated by merauder75 over 6 years ago
It's implemented by long-pressing the game in the list of games, so a message of some sort may be appropriate.
Updated by JosJuice over 6 years ago
Yeah, I think it would be good to go with a message then.
Updated by ryanebola16 over 6 years ago
On Windows Dolphin you don't have the option to open game properties for DOL or ELF. Since the only Android long press options are game specific overrides, I'd rather have a message than users being confused as to why their long press does nothing for DOL or ELF.
Updated by ryanebola16 over 6 years ago
Updated by JosJuice over 6 years ago
- Status changed from Accepted to Fixed
- Fixed in set to 5.0-8068