Project

General

Profile

Actions

Emulator Issues #10947

closed

Android: Changing Ubershaders setting doesn't change "UberShaderMode" in INI

Added by ryanebola16 almost 7 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Android
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
5.0-6461
Fixed in:
5.0-6491

Description

What's the problem? Describe what went wrong.

Changing Ubershaders setting doesn't change "UberShaderMode" in GFX.ini. For Hybrid Ubershaders, "BackgroundShaderCompiling" = True and "DisableSpecializedShaders" = False. Exclusive Ubershaders flips those settings. Manually setting UberShaderMode = 1 crashes Dolphin. Is this intentional?

What steps will reproduce the problem?

  1. Change the Ubershaders setting.
  2. Observe GFX.ini problems with both hybrid and exclusive Ubershaders.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

5.0-6458

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

Enabling Ubershaders in the GUI before 5.0-6461 crashed Dolphin. I assume that this PR changed the behavior of the Ubershader setting to not edit "UberShaderMode"? Does this mean Ubershaders are not working even though the setting is enabled?

What are your PC specifications? (CPU, GPU, Operating System, more)

Samsung Galaxy Note8 (SM-N950U)
Qualcomm Snapdragon 835
Octa-core (4x2.35 GHz Kryo & 4x1.9 GHz Kryo)
Adreno 540
6GB RAM (LPDDR4)
Baseband version N950USQS2BQK2
Kernel version 4.4.21
Android 7.1.1

Actions

Also available in: Atom PDF