Project

General

Profile

Actions

Emulator Issues #10957

open

Android: Prefer INI settings instead of SharedPreferences to retain settings across Dolphin builds

Added by ryanebola16 about 6 years ago. Updated over 3 years ago.

Status:
Fix pending
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
Android
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Title says it all. Problem occurs even when uninstalling then reinstalling the same Android Studio-built APK.


Related issues 1 (0 open1 closed)

Related to Emulator - Emulator Issues #12067: [Feature request, Android] Allow manual configuration of device orientation before game startFixed

Actions
Actions #1

Updated by JosJuice about 6 years ago

  • Status changed from New to Questionable
  • Operating system Android added
  • Operating system deleted (N/A)
Actions #2

Updated by ryanebola16 about 6 years ago

This also occurs with PRs built by the buildbot.

Actions #3

Updated by JMC4789 about 6 years ago

I thought this was intended? Every single APK has its own settings and whatnot on Android?

Actions #4

Updated by ryanebola16 about 6 years ago

Updating to a new master branch build doesn't have this problem but a buildbot or Android Studio build of a PR does. I don't think that's something we want.

Actions #5

Updated by ryanebola16 over 4 years ago

Expanding this issue a little:
Certain settings use default values when installing Android Studio built Dolphin (Dolphin exists as a separate app on Android from buildbot built apps), or uninstalling buildbot Dolphin on Android and then installing an older buildbot version. Some of these settings include:

  • Analytics permission
  • Game directory path
  • Enabled controllers
  • Default controller for emulation
  • Rumble setting
  • Controller layout

It's really annoying when these settings need to constantly be set to test issues. Ideally, these settings should be retained across builds of Dolphin.

Actions #6

Updated by JosJuice over 4 years ago

Ah, so the problem isn't when updating an existing Android Studio install, only when you didn't have an existing install with the same package name (either because you uninstalled it or because you didn't have one to begin with)? Then I understand, and can reproduce it perfectly.

I agree that it is annoying... But on the other hand, that's how Android apps are intended to work. We will probably actually need to remove the ability to automatically carry over any settings at all in the future once scoped storage becomes mandatory. At that point we would probably want to add some kind of convenient data import/export feature.

Actions #7

Updated by ryanebola16 over 4 years ago

Yes, sorry I knew something was wrong at the time of writing the report but I hadn't tested enough install/reinstall cycles to say what I know now. But even with scoped storage, shouldn't it still be possible for Dolphin to read settings from an INI file via storage access framework APIs? I think that the settings I previously mentioned should be set in an INI and readable across all Dolphin builds, regardless of package name.

Actions #8

Updated by JosJuice over 4 years ago

Yes, if the user manually selects a location for Dolphin to store its data at. This would need to be done for every installation of the app. Otherwise we can only access the app-specific storage, which gets wiped on uninstall – if I'm understanding it correctly, that is.

Actions #9

Updated by ryanebola16 over 4 years ago

I had the same understanding from what I briefly read. I guess this can be revisited when shared storage is implemented for Dolphin.

Actions #10

Updated by ryanebola16 over 4 years ago

I had the same understanding from what I briefly read. I guess this can be revisited when scoped storage is implemented for Dolphin.

Actions #11

Updated by ryanebola16 almost 4 years ago

  • Subject changed from Android: APKs built in Android Studio never recognize game lists or controller layout after installing to Android: Prefer INI settings instead of SharedPreferences to retain settings across Dolphin builds
  • Status changed from Questionable to Accepted

I think this is the underlying issue.

Actions #12

Updated by ryanebola16 almost 4 years ago

  • Status changed from Accepted to Work started
Actions #13

Updated by ryanebola16 almost 4 years ago

  • Related to Emulator Issues #10962: Android: Make "Choose Controller" menu accessible outside of emulation added
Actions #14

Updated by ryanebola16 almost 4 years ago

  • Related to Emulator Issues #12067: [Feature request, Android] Allow manual configuration of device orientation before game start added
Actions #15

Updated by ryanebola16 almost 4 years ago

  • Assignee set to ryanebola16
Actions #16

Updated by ryanebola16 almost 4 years ago

  • Related to deleted (Emulator Issues #10962: Android: Make "Choose Controller" menu accessible outside of emulation)
Actions

Also available in: Atom PDF