Emulator Issues #11170
open
Debug Symbol issue with Add Function
0%
Description
What's the problem? Describe what went wrong.
Old behavior: Add Function renames a single instruction line, does not break original symbol block.
After optimization build: Add function splits a symbol block in half. Cannot load old symbol files correctly.
What steps will reproduce the problem?
Use Right Click -> Add Function on an instruction in the middle of a symbol block in a build before and after 5.0-5475.
Loading a symbol file with single instruction symbols will also turn out incorrectly on bugged builds.
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
5.0 7767, Issue Present
Is the issue present in the latest stable version?
Not in 5.0.
If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
5.0-5475
If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer
Left: New / Right: Old
I don't know if anyone is relying on the new behavior, but options to change the size of symbol blocks now exist, so you should be able to split a symbol block into two using other methods even if the bug is fixed.
Updated by taolas almost 6 years ago
8005ac18 00001270 8005ac18 0 xx_RunSpeed,Ice1
8005b200 00000c88 8005b200 0 xx_Slope_Check
Whenever you try to split a symbol function, in any version, the original function will keep its size (1270). In older versions when a second, overlapping symbol comes up, it conforms to the first line / size, except when a particular line is mentioned (causing single line comments). In new versions, it forgets the first line when a new symbol comes up.
Single line symbols may not be intended behavior, and may require an additional single-line comment feature apart from symbols. I'm not sure what should be preferred behavior when symbols overlap. Perhaps sticking with the old version is best for file compatibility? There could also be an opportunity here to tweak it to allow for embedding a symbol block inside a larger block, but I'm not sure if that's a proper way to use symbols.