Project

General

Profile

Actions

Emulator Issues #11201

closed

Exported Wii Save files from Dolphin versions older than 5.0-7988 can't be imported into Dolphin versions 5.0-7988 and newer

Added by master0fdisaster1 almost 6 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
High
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
5.0-7988
Fixed in:
5.0-8035

Description

What's the problem? Describe what went wrong.

If you are exporting a savefile with a version of Dolphin older than 5.0-7988, importing that savefile with 5.0-7988 or newer will give you the error "Failed to import save files."

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes 5.0-8021

Is the issue present in the latest stable version?

No

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

5.0-7988

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)


Files

NAAE 5.0-7988.bin (77.3 KB) NAAE 5.0-7988.bin SM64 savefile exported with version 5.0-7988 master0fdisaster1, 06/04/2018 08:35 PM
NAAE 5.0-7984.bin (60.2 KB) NAAE 5.0-7984.bin SM64 savefile exported with version 5.0-7984 master0fdisaster1, 06/04/2018 08:35 PM
Actions #1

Updated by JMC4789 almost 6 years ago

  • Status changed from New to Fix pending
Actions #2

Updated by master0fdisaster1 almost 6 years ago

I tested the pr and it can import wii saves from dolphin versions older than 5.0-7972 and newer than 5.0-7984.

Actions #3

Updated by leoetlino almost 6 years ago

  • Priority changed from Normal to High
  • Regression changed from No to Yes
  • Easy changed from No to Yes
  • Regression start set to 5.0-7988

Yeah, the meaning of a data field was changed by mistake. This also ended up breaking compatibility with saves exported in the System Menu.

Actions #4

Updated by master0fdisaster1 almost 6 years ago

I just wanted to add for completeness' sake that exporting savefiles with versions 7972,7974,7976 and 7984 crashes Dolphin (but it still creates a .bin file) and that the savefiles made with those version can't be imported by any version, not even with the version they're made with.

I also mixed up my savefiles and the attached "NAAE 5.0-7988.bin" was actually made with version 7991.
Version 7988 also fails when exporting savefiles, although it doesn't crash, it just gives you an error message (it still creates a .bin file). And just like the previous 4 versions that savefile also can't be imported by any version including 7988 itself.

So the pr can actually import savefiles from dolphin versions older than 5.0-7972 and newer than 5.0-7988.

The regression of not importing older savefiles still started with 7988.

Actions #5

Updated by leoetlino almost 6 years ago

I couldn't reproduce the crash, but since you say it's fixed...

Actions #6

Updated by leoetlino almost 6 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-8035

Fixed. Thanks for your report.

Actions

Also available in: Atom PDF