Emulator

Use the bisect tool to bisect to find the exact build when the behavior changed. https://forums.dolphin-emu.org/Thread-green-notice-development-thread-dolphin-bisection-tool-for-finding-broken-builds

MayImilae wrote:

Use the bisect tool to bisect to find the exact build when the behavior changed. https://forums.dolphin-emu.org/Thread-green-notice-development-thread-dolphin-bisection-tool-for-finding-broken-builds

Using the bisect tool, I've managed to find the build that broke it. It's 5.0-2830. I also checked it by myself after the bisect told me the result: Widescreen hack works in N64 games in 5.0-2826 and it's broken in 5.0-2830 which is the very next build. So there you have it!

Sorry for not doing this before, I assumed it would be more complicated.

I've also noticed when selecting the "Auto" aspect ratio option in the graphic settings, Dolphin 5.0-2826 and older versions will properly detect that the game is 4:3 and render in 4:3, while 5.0-2830 will stretch it to 16:9 when it's set to Auto. Setting the aspect ratio to "Force 16:9" makes no difference: the widescreen hack will still do nothing from 2830 onwards.

5.0-2830 broke some stuff related to game INIs for downloadable Wii games, which was fixed again in 5.0-3008. The reason that is relevant to this issue is because the game INIs for VC games contain a line saying that they don't have 16:9 support (which Dolphin otherwise assumes that Wii games have).

Could you re-test your issue in both 5.0-2830 and the latest version with the Wii aspect ratio setting set to 4:3? (To clarify, I want you to edit the setting that's in the Wii tab of the general config, not the one that's in the graphics configuration window.)

JosJuice wrote:

5.0-2830 broke some stuff related to game INIs for downloadable Wii games, which was fixed again in 5.0-3008. The reason that is relevant to this issue is because the game INIs for VC games contain a line saying that they don't have 16:9 support (which Dolphin otherwise assumes that Wii games have).

Could you re-test your issue in both 5.0-2830 and the latest version with the Wii aspect ratio setting set to 4:3? (To clarify, I want you to edit the setting that's in the Wii tab of the general config, not the one that's in the graphics configuration window.)

Yup. If I set the Wii aspect ratio setting in the general config to 4:3, the widescreen hack works again in both 2830 and the latest development version. But according to what you say, this shouldn't happen, as Dolphin should know that the game is 4:3, so it should ignore the 16:9 Wii setting, no?

Yes, it should work like you say in the latest development build (but not in 5.0-2830). Could you test 5.0-3008 too? If that version doesn't have the problem, you should do a bisect between 5.0-3008 and the latest version.

JosJuice wrote:

Yes, it should work like you say in the latest development build (but not in 5.0-2830). Could you test 5.0-3008 too? If that version doesn't have the problem, you should do a bisect between 5.0-3008 and the latest version.

5.0-3008 does not have the problem. I did a bisect as you said and the result is that 5.0-3305 broke it. And the changelog looks suspicious!

Merge pull request #5008 from ligfx/aspectheuristic
VideoCommon: rework anamorphic widescreen heuristic

It has the same broken behaviour as the latest development build:

• Wii aspect ratio set to 16:9 = The game is detected and rendered as a 16:9 title, widescreen hack doesn't work, neither in Auto aspect ratio or force 16:9 aspect ratio (in the graphic settings)
• Wii aspect ratio set to 4:3 = The game is detected and rendered as a 4:3 title, widescreen hack does work if you select Force 16:9 in the graphic settings.