Project

General

Profile

Actions

Emulator Issues #11285

closed

Aspect ratio is incorrect when using "Crop" option

Added by ligfx over 6 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-9287

Description

What's the problem? Describe what went wrong.

When using the "Crop" option, games will have a different aspect ratio when the window is wider than the image (e.g. it could be cropped on the top and bottom) vs. the window is taller than the image (e.g. it could be cropped on the sides).

I've attached two screenshots of SSX Tricky in anamorphic widescreen mode with Crop enabled to illustrate the issue. When the window is wider than the image, the image has an aspect ratio of about ~1.78. When the window is taller than the image, the image has an aspect ratio of about ~1.74.

What steps will reproduce the problem?

  1. Choose a game that doesn't output a perfectly 4:3 or 16:9 image (e.g. SSX Tricky in anamorphic widescreen mode, or most games)
  2. Enable crop
  3. Resize the window

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes: 5.0-8449

Which is the first broken version?

This issue was introduced by PR #6786: RenderBase: Ensure the draw size does not exceed the window size ([[https://github.com/dolphin-emu/dolphin/pull/6786]]) / 5.0-7439


Files

Actions #1

Updated by ligfx over 6 years ago

Revert to previous behavior available at: https://github.com/dolphin-emu/dolphin/pull/7230

Actions #2

Updated by JosJuice almost 6 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-9287
Actions

Also available in: Atom PDF