Project

General

Profile

Emulator Issues #11292

Qt/macOS: A few buttons that don't use the native system UI

Added by 8times9 almost 3 years ago. Updated about 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

I found two instances of buttons not using the native system UI on macOS, see attached screenshots.

They are the mapping modification buttons in the advanced mapping window and the dropdown menu in the NetPlay window.

History

#2 Updated by Techjar almost 3 years ago

These are unfortunately a result of MacOS not having a native style for QPushButtons with QSizePolicy::Expanding, and QToolButton in general. Not sure if there's any workaround for this.

#3 Updated by Techjar almost 3 years ago

See how this build affects the "Configure Input" window: https://dl.dolphin-emu.org/prs/pr-7279-dolphin-latest.dmg

#4 Updated by 8times9 almost 3 years ago

Partially fixed in 5.0-8480

#5 Updated by 8times9 about 2 years ago

A few more have come up:
- Presets button in Game Config Editor tab of Properties
- Calibrate buttons in mapping window

#6 Updated by 8times9 about 2 years ago

Presets buttons have been fixed in 5.0-9701

#7 Updated by 8times9 about 2 years ago

7322

Here's a screenshot of what the Calibrate buttons look like on macOS.

#8 Updated by Techjar about 2 years ago

The only solution for the calibrate buttons would be to make them a QPushButton with a menu, like the game config editor presets menu. This is not an acceptable solution though, as it makes them less intuitive to use, since we can only have a menu and not a default push action.

#9 Updated by 8times9 about 2 years ago

That's true, but I feel like the buttons being slightly less convenient to use is better than how they currently look. Of course, there's no reason to punish Linux and Windows users for a macOS limitation, so maybe they could be made into QPushButtons only on macOS.

If this were a much less-used window like somewhere in debugging, leaving the buttons as is would be just fine. But the GameCube/Wiimote mapping windows are very frequently visited – I know I use them at least once every time I play games on Dolphin.

#10 Updated by Techjar about 2 years ago

The particular way we use QToolButton there isn't feasible to change without a complete redesign of it, unfortunately. It's not a simple matter of swapping out the button type. Various behaviors are dependent on that being a button with a default action.

#11 Updated by 8times9 about 2 years ago

Understandable, thanks for checking on it though.

Also available in: Atom PDF