Project

General

Profile

Actions
Copy link

Emulator Issues #11292

open

Qt/macOS: A few buttons that don't use the native system UI

Added by 8times9 over 6 years ago. Updated about 2 years ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
OS X
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

I found two instances of buttons not using the native system UI on macOS, see attached screenshots.

They are the mapping modification buttons in the advanced mapping window and the dropdown menu in the NetPlay window.

Files

Download all files
Screen Shot 2018-07-17 at 10.38.21 AM.png (63.1 KB) Screen Shot 2018-07-17 at 10.38.21 AM.png 8times9, 07/17/2018 03:44 PM
Screen Shot 2018-07-17 at 10.38.35 AM.png (77.8 KB) Screen Shot 2018-07-17 at 10.38.35 AM.png 8times9, 07/17/2018 03:44 PM
Calibrate buttons.png (19.2 KB) Calibrate buttons.png 8times9, 03/26/2019 11:24 PM
Screen Shot 2022-10-25 at 15.11.39.png (47 KB) Screen Shot 2022-10-25 at 15.11.39.png OatmealDome, 10/25/2022 07:11 PM
Actions
Copy link
 #2

Updated by Techjar over 6 years ago

These are unfortunately a result of MacOS not having a native style for QPushButtons with QSizePolicy::Expanding, and QToolButton in general. Not sure if there's any workaround for this.

Actions
Copy link
 #3

Updated by Techjar over 6 years ago

See how this build affects the "Configure Input" window: https://dl.dolphin-emu.org/prs/pr-7279-dolphin-latest.dmg

Actions
Copy link
 #4

Updated by 8times9 over 6 years ago

Partially fixed in 5.0-8480

Actions
Copy link
 #5

Updated by 8times9 almost 6 years ago

A few more have come up:

  • Presets button in Game Config Editor tab of Properties
  • Calibrate buttons in mapping window
Actions
Copy link
 #6

Updated by 8times9 almost 6 years ago

Presets buttons have been fixed in 5.0-9701

Actions
Copy link
 #7

Updated by 8times9 over 5 years ago

Here's a screenshot of what the Calibrate buttons look like on macOS.

Actions
Copy link
 #8

Updated by Techjar over 5 years ago

The only solution for the calibrate buttons would be to make them a QPushButton with a menu, like the game config editor presets menu. This is not an acceptable solution though, as it makes them less intuitive to use, since we can only have a menu and not a default push action.

Actions
Copy link
 #9

Updated by 8times9 over 5 years ago

That's true, but I feel like the buttons being slightly less convenient to use is better than how they currently look. Of course, there's no reason to punish Linux and Windows users for a macOS limitation, so maybe they could be made into QPushButtons only on macOS.

If this were a much less-used window like somewhere in debugging, leaving the buttons as is would be just fine. But the GameCube/Wiimote mapping windows are very frequently visited – I know I use them at least once every time I play games on Dolphin.

Actions
Copy link
 #10

Updated by Techjar over 5 years ago

The particular way we use QToolButton there isn't feasible to change without a complete redesign of it, unfortunately. It's not a simple matter of swapping out the button type. Various behaviors are dependent on that being a button with a default action.

Actions
Copy link
 #11

Updated by 8times9 over 5 years ago

Understandable, thanks for checking on it though.

Actions
Copy link
 #12

Updated by spycrab0 over 5 years ago

Actions
Copy link
 #13

Updated by OatmealDome about 2 years ago

While most of these buttons have been removed, there are still two instances of QToolButton being used: the Calibrate button in MappingWindow, and the Export as GCI button in the memory card manager. (The latter is particularly ugly looking because it doesn't even match the size of the other QPushButtons.)

Actions
Copy link
 #14

Updated by Billiard26 about 2 years ago

  • Operating system OS X added
  • Operating system deleted (N/A)
Actions
Copy link

Also available in: Atom PDF