Project

General

Profile

Actions

Emulator Issues #11314

open

Qt: Make Layout more compact

Added by nwplayer123 over 6 years ago. Updated over 5 years ago.

Status:
Questionable
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Task
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

A "compact" mode for Dolphin would be highly appreciated, right now Qt takes up too much screen space for some people (e.g. me).


Files

Screenshot_120.png (150 KB) Screenshot_120.png Wx nwplayer123, 08/02/2018 03:07 AM
Screenshot_119.png (138 KB) Screenshot_119.png Qt nwplayer123, 08/02/2018 03:07 AM
Screenshot_127.png (34.8 KB) Screenshot_127.png ToolBar nwplayer123, 08/03/2018 09:44 AM
Screenshot_128.png (7.62 KB) Screenshot_128.png Disappearing sections nwplayer123, 08/03/2018 09:48 AM
Screenshot_129.png (2.18 KB) Screenshot_129.png Qt game spacing nwplayer123, 08/03/2018 09:56 AM
Screenshot_130.png (246 KB) Screenshot_130.png Wx font size nwplayer123, 08/03/2018 09:58 AM
Screenshot_131.png (2.81 KB) Screenshot_131.png ugly pop-out bar nwplayer123, 08/03/2018 10:00 AM
Screenshot_132.png (47 KB) Screenshot_132.png Qt Audio tab nwplayer123, 08/03/2018 10:03 AM
Screenshot_133.png (42.9 KB) Screenshot_133.png Wx Audio tab nwplayer123, 08/03/2018 10:03 AM
Screenshot_134.png (40.6 KB) Screenshot_134.png Qt Paths tab nwplayer123, 08/03/2018 10:05 AM
Screenshot_135.png (59.8 KB) Screenshot_135.png Controller Settings nwplayer123, 08/03/2018 10:07 AM
Screenshot_529.png (90.5 KB) Screenshot_529.png nwplayer123, 04/24/2019 02:39 AM
Screenshot_530.png (49 KB) Screenshot_530.png nwplayer123, 04/24/2019 02:39 AM
Screenshot_531.png (16.1 KB) Screenshot_531.png nwplayer123, 04/24/2019 02:39 AM
Screenshot_532.png (13 KB) Screenshot_532.png nwplayer123, 04/24/2019 02:39 AM
Screenshot_533.png (153 KB) Screenshot_533.png nwplayer123, 04/24/2019 02:39 AM

Related issues 1 (0 open1 closed)

Related to Emulator - Emulator Issues #11019: QT control customization pane missing features and regression from WXFixedBilliard26

Actions
Actions #1

Updated by JMC4789 over 6 years ago

  • Assignee set to spycrab0

The debug GUI is very tough to fit on a single monitor, but maybe a redesign that takes advantage of Qt's benefits would be better than an extra configuration mode?

Actions #2

Updated by spycrab0 over 6 years ago

  • Issue type changed from Bug to Feature request
Actions #3

Updated by spycrab0 over 6 years ago

  • Status changed from New to Fix pending

https://github.com/dolphin-emu/dolphin/pull/7299. This should make the spacing more compact. You should also reduce your debugger font size.

Updated by nwplayer123 over 6 years ago

I don't think this goes far enough, also I found some bugs.

  1. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/DolphinQt/ToolBar.cpp#L135 is what makes the icons way wider than they need to be (see original post), I just removed that whole code chunk, can't figure out how to make the text and icon have less spacing like Wx but that'll work better

  2. I fiddled with the debugger stuff some more, https://github.com/dolphin-emu/dolphin/pull/7299/files#diff-41a00b5b09ef5aedac65735e3f0ede62R43 doesn't actually do anything, and the sections can resize to 0 and disappear (but will reappear when you resize it back), not sure if that's intentional, maybe set a minimum height

2.5) In https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/DolphinQt/Debugger/CodeWidget.cpp#L84, I found this worked better

layout->setContentsMargins(6, 6, 6, 8);
m_search_address->setContentsMargins(0, 0, 5, 5);
m_search_symbols->setContentsMargins(0, 0, 0, 5);
callstack_box->setContentsMargins(0, 6, 0, 0);
callstack_layout->setSpacing(0);
callstack_layout->setContentsMargins(6, 14, 6, 6);
symbols_box->setContentsMargins(0, 6, 0, 0);
symbols_layout->setSpacing(0);
symbols_layout->setContentsMargins(6, 14, 6, 6);
function_calls_box->setContentsMargins(0, 6, 0, 0);
function_calls_layout->setSpacing(0);
function_calls_layout->setContentsMargins(6, 14, 6, 6);
function_callers_box->setContentsMargins(0, 6, 0, 0);
function_callers_layout->setSpacing(0);
function_callers_layout->setContentsMargins(6, 14, 6, 6);
  1. I don't see an option to "reduce" my debugger font size, it comes like that out of the box, probably high DPI problems since this is a 4K display, Wx was fine out of the box

  2. I didn't try to poke at this, but removing that padding between each game entry so it's just a solid column of banners (maybe 1px) in Screenshot_129 would help since it's that much more vertical space

  3. I didn't try to figure this out either, but it'd be nice to remove this ugly bar for the pop-out windows and make the tabs do the same thing, not sure if Qt allows that

  4. Audio tab needs scroll bar disabled, and changing the layout so the volume doesn't extend all the way down, e.g. Wx would be nice

  5. Same with paths, scrollbar should be probably be inside the paths box, also making a HBoxLayout so the checkboxes are to the left of the Add/Remove, not below, would probably have to change the text for that so it doesn't get cut off

  6. More nitpicking, would be nice to have this text to the left like the GameCube ones are (I know it's cuz of the button but can probably do negative margin something)

Sorry for being super nitpicky, feel free to ignore any number of these requests

Actions #5

Updated by spycrab0 over 6 years ago

  • Subject changed from Qt: Feature Request - Compact Mode to Qt: Make Layout more compact
  • Status changed from Fix pending to Work started
  • Issue type changed from Feature request to Task

Note that I only worked on the debugger widgets and things not related to the debugger will have to go into another PR.

Wx was fine out of the box

Wx just used some hardcoded number out-of-the-box. We just take your standard system monospace font. You can find the option to change your debugger font under Options -> Font while the debugging mode is active.

Audio tab needs scroll bar disabled, and changing the layout so the volume doesn't extend all the way down, e.g. Wx would be nice

No, this is intended. It shouldn't show up by default though but this is a separate issue and should be handled as such.

Same with paths, scrollbar should be probably be inside the paths box, also making a HBoxLayout so the checkboxes are to the left of the Add/Remove, not below, would probably have to change the text for that so it doesn't get cut off

the sections can resize to 0 and disappear (but will reappear when you resize it back), not sure if that's intentional, maybe set a minimum height

Intentional in case someone wants to hide them.

Don't really see much of an issue with this one either to be honest. Also might be better off being handled separately.

More nitpicking, would be nice to have this text to the left like the GameCube ones are (I know it's cuz of the button but can probably do negative margin something)

I'm just going to assume this is related to Screenshot_135.png for now: This is emphasized to show that these options are actually "children" of the radio buttons and will be toggled because of them.

I didn't try to poke at this, but removing that padding between each game entry so it's just a solid column of banners (maybe 1px) in Screenshot_129 would help since it's that much more vertical space

This is already subject of another issue report, so it'd better off being handled there.

Actions #6

Updated by spycrab0 almost 6 years ago

  • Assignee deleted (spycrab0)
Actions #7

Updated by spycrab0 over 5 years ago

  • Status changed from Work started to Questionable

Are there still complaints about the compactness or has this been addressed to a satisfactory degree?

Updated by nwplayer123 over 5 years ago

Oh man, looked at commits, you've been busy, um.
Couple nitpicks:

  • Memory viewer clips (at least on my 4K display)
  • there's no actual divider between debug part and listing
  • code has this weird resizing to fit the whole line (not sure if/how that's "fixable")
  • make game list toggleable (so it's not taking up space when debugging, and also so I can hide it completely if I just need one game, can just hit "play" whenever I need to restart it)
  • I'd love an option to use uppercase hex instead of lowercase

then yes, I'll be happy

Actions #9

Updated by Billiard26 9 months ago

  • Related to Emulator Issues #11019: QT control customization pane missing features and regression from WX added
Actions

Also available in: Atom PDF