Project

General

Profile

Emulator Issues #11323

Some games (e.g. Mario Kart Wii) are not properly informed about controller removal

Added by Lettendo almost 3 years ago. Updated about 2 years ago.

Status:
New
Priority:
Low
Assignee:
-
% Done:

0%

Operating system:
Windows
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

Every wired Controller supporting game.

What's the problem? Describe what went wrong.

If a real wired controller is unplugged (In my case the Xbox One Controller which I use to emulate a GameCube Controller), the emulated game will not be informed about this. (e.g. Mario Kart Wii). Normally, MKW would then display a message about which controller was plugged out.

What steps will reproduce the problem?

  1. Use a real, removable controller as GameCube controller.
  2. Start a game that supports GameCube Controller. (e.g., Mario Kart Wii)
  3. Press in title screen A with the controller.
  4. Plug out the real controller.

Expected result:
A message appears.

Actual result:
No message appears.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, 5.0-8512.

Is the issue present in the latest stable version?

I would guess, yes. But I did not test it.

What are your PC specifications? (CPU, GPU, Operating System, more)

I think that's not important.

GCPad config.png (28 KB) GCPad config.png JosJuice, 04/17/2019 01:42 PM
Unbenannt.PNG (113 KB) Unbenannt.PNG screenshot of my controller configuration Lettendo, 04/17/2019 02:14 PM
7369
7370

Related issues

Related to Emulator - Emulator Issues #11165: Controller hotplug issue in SoulCalibur IIAccepted

History

#1 Updated by JMC4789 almost 3 years ago

Do you have the option "Always Connected" selected in the Controller Settings page?

#2 Updated by Lettendo almost 3 years ago

No, I did not activate this option.

#3 Updated by JMC4789 almost 3 years ago

  • Priority changed from Normal to Low

I tested it with my wired PS4 controller and unplugging it does tell the game its no longer connected... so I'm guessing this is more "xinput is terrible in Dolphin." stuff.

#4 Updated by Billiard26 over 2 years ago

#5 Updated by Billiard26 over 2 years ago

  • Subject changed from Game is not informed about a wired controller removal to Game is not informed about XInput controller removal
  • Operating system Windows added
  • Operating system deleted (N/A)

Assuming Windows. (poster decided it wasn't important to list operating system :/)
So this would be fixed by XInput hotplug support. (#6047)

#6 Updated by JMC4789 over 2 years ago

  • Status changed from New to Fix pending

#7 Updated by Lettendo over 2 years ago

Yes, I'm using Windows 10. I only thought about CPU and GPU when I said "I think that's not important" :/

#8 Updated by JMC4789 over 2 years ago

Yeah, it's one of those edge cases where controller handling is different between OSes.

#9 Updated by Billiard26 about 2 years ago

  • Fixed in set to 5.0-9869
  • Status changed from Fix pending to Fixed

#10 Updated by Lettendo about 2 years ago

Thanks for adding hotplugging support for XInput controllers. But unfortunately, the game is still not informed about a controller removal. I tested this using Mario Kart Wii. Normally the game would display a message about which gamecube controller was plugged out. But it doesn't.

#11 Updated by Lettendo about 2 years ago

I was using version 5.0-9888 when testing.

#12 Updated by JosJuice about 2 years ago

  • Fixed in deleted (5.0-9869)
  • Status changed from Fixed to New

#13 Updated by Billiard26 about 2 years ago

@Luis Please show a screenshot of your GCPad configuration.

#14 Updated by JosJuice about 2 years ago

7369

I reproduced the issue using this configuration (5.0-9974):

#15 Updated by Lettendo about 2 years ago

7370

I am using this configuration.

#16 Updated by Billiard26 about 2 years ago

#17 Updated by Billiard26 about 2 years ago

#18 Updated by Billiard26 about 2 years ago

  • Subject changed from Game is not informed about XInput controller removal to Some games are not properly informed about controller removal.

This has nothing to do with XInput.

I'll quote what I said in the related SoulCalibur issue #11165.

"FYI. This is caused by our means of emulating a "Null" device when a "GCController" is chosen but the user's gamepad is not present.
We send the appropriate responses of CSIDevice_Null in this situation but we never call SetNoResponse like ChangeDeviceCallback does.
Adding this call does fix the issue but calling it directly isn't really a clean solution."

#19 Updated by Billiard26 about 2 years ago

  • Subject changed from Some games are not properly informed about controller removal. to Some games (e.g. Mario Kart Wii) are not properly informed about controller removal

Also available in: Atom PDF