Emulator Issues #11335
closed
Qt Controller Config menu: Dolphin crashes if menu is closed while button is waiting for configuration.
0%
Description
Seen on 5.0-8545 (bb255d266635f4a39d616c35b4670a7bb7dde795), Windows.
You'll need a controller plugged in for this; or more specifically, you need the wait-for-input-config thread to not react to mouse/keyboard input.
Open the config window for Gamecube Controllers (or Wiimotes, whichever) and select the controller as the Device in the top left. Click on any button configuration, (eg: C Stick Up), then quickly, while the button is in the '...' state, close the window. After a few seconds, the button will time out, and Dolphin will crash -- or maybe it'll crash a bit later, we're accessing deleted memory here so the specifics can differ.
In Debug mode, the crash happens at Core\DolphinQt\Config\Mapping\MappingButton.cpp line 176 with an access violation somewhere in the Qt code for QString.isEmpty().
Related, you can trigger multiple buttons to wait for input at the same time, which doesn't seem quite right either.
Files
Updated by AdmiralCurtiss over 5 years ago
- File Clipboard04.png Clipboard04.png added
Hm, I think I might have misinterpreted the location of the crash, I actually think it's a line above that in removeEventFilter() -- the 'this' object that removeEventFilter() is called on is deleted.
Updated by spycrab0 over 5 years ago
- Status changed from New to Accepted
- Assignee set to spycrab0
- Priority changed from Normal to Low
Can reproduce.
Updated by spycrab0 over 5 years ago
- Status changed from Accepted to Fix pending
Updated by spycrab0 over 5 years ago
- Status changed from Fix pending to Fixed
- Fixed in set to 5.0-8563