Project

General

Profile

Emulator Issues #11423

FFmpeg: Frame dumping gets disabled when declining to overwrite exiting video file

Added by Anonymous over 2 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem? Describe what went wrong.

Frame dumping doesn't stay enabled, running the game again will not reprompt and will not start dumping frames, the button still shows as if dumping frames is enabled, after rebooting dolphin the frame dumps are disabled.

What steps will reproduce the problem?

Start Dolphin and enable frame dumping
Start a title, frame dumping in progress
Stop emulating a title
A: Start same or another title
B: Reboot dolphin and start same or another title

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

5.0-8909

Is the issue present in the latest stable version?

No

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

If necessary :)

What are your PC specifications? (CPU, GPU, Operating System, more)

Win10, Intel Core i7 3820, AMD RX480

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Could be a qt thing

History

#1 Updated by Techjar over 2 years ago

Sounds like the UI just isn't being updated to reflect the change.

#2 Updated by Anonymous over 2 years ago

I forgot to mention, it doesn't get just disabled in one session, it overwrrides the actual saved configuration and actually overwrites it.

So even in this case: If you start Dolphin with frame dumping enabled, you answer NO to that question, you quit it and reopen Dolphin, you'll have frame dumping disabled. I couldn't figure it out, looking at the code back up in RenderBase ... but I didn't look out of that.

#3 Updated by Techjar over 2 years ago

That makes sense, we need to disable frame dumping in order to continue running if the user says no.

#4 Updated by Anonymous over 2 years ago

It make sense only for the that emulation session, not the rest of them IMO - that's how it works in 5.0

And, that same question could have worked in another method, in case of simply writing to another name.

Also available in: Atom PDF