Emulator Issues #11491
Gecko code downloading fails to parse codes with XXs
Metroid prime trilogy us
Game ID? (right click the game in the game list, properties, info tab)
[Put Game ID here]
MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)
[Put MD5 Hash here]
What's the problem? Describe what went wrong.
I downloaded gecko codes but the latest revision reads them as 00000000 00000000.
What steps will reproduce the problem?
Download gecko codes for a game.
[Reproduction steps here]
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
[Version number here]
Is the issue present in the latest stable version?
[Yes/No and version number here]
If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
[First broken version number here (if applicable)]
If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer
[Attach any fifologs if possible, write a description of fifologs and screenshots here to assist people unfamiliar with the game.]
What are your PC specifications? (CPU, GPU, Operating System, more)
[PC specs here]
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
[Anything else here]
#3 Updated by Billiard26 4 months ago
- Status changed from New to Accepted
Right now dolphin assumes each code is a list of valid 8-character hexadecimal numbers.
They are parsed using c++'s std::istringstream.
It definitely fails when codes have Xs in them. (when the user is supposed to configure some value)
e.g. 3C808049 3C60XXXX is read as 3C808049 00003C60.
It's possible your system language (Russian?) has something to do with it.
I wouldn't be totally surprised if std::stringstream was the culprit.
We should probably use something else to parse and fix the "X" character cases anyways..