Emulator Issues #11491
openGecko code downloading fails to parse codes with XXs
0%
Description
Game Name?
Metroid prime trilogy us
Game ID? (right click the game in the game list, properties, info tab)
R3ME01
[Put Game ID here]
MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)
2ac7eefe7c76b1bd1e6d407565735c18
[Put MD5 Hash here]
What's the problem? Describe what went wrong.
I downloaded gecko codes but the latest revision reads them as 00000000 00000000.
[Description here]
What steps will reproduce the problem?
Download gecko codes for a game.
[Reproduction steps here]
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
yes 9211
[Version number here]
Is the issue present in the latest stable version?
no
[Yes/No and version number here]
Dolphin 5.0
If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
[First broken version number here (if applicable)]
If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer
[Attach any fifologs if possible, write a description of fifologs and screenshots here to assist people unfamiliar with the game.]
What are your PC specifications? (CPU, GPU, Operating System, more)
[PC specs here]
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
[Anything else here]
Files
Updated by JosJuice about 6 years ago
Please bisect. It's much harder for us to find the issue otherwise.
Updated by JosJuice about 6 years ago
- Subject changed from Gecko codes are broken. to Downloading Gecko codes is broken
Updated by Billiard26 almost 6 years ago
- Status changed from New to Accepted
Right now dolphin assumes each code is a list of valid 8-character hexadecimal numbers.
They are parsed using c++'s std::istringstream.
It definitely fails when codes have Xs in them. (when the user is supposed to configure some value)
e.g. 3C808049 3C60XXXX is read as 3C808049 00003C60.
It's possible your system language (Russian?) has something to do with it.
I wouldn't be totally surprised if std::stringstream was the culprit.
We should probably use something else to parse and fix the "X" character cases anyways..
Updated by Billiard26 almost 6 years ago
- Related to Emulator Issues #11133: macOS - Gecko codes are parsed incorrectly (zeros) added
Updated by flacs almost 6 years ago
- Status changed from Accepted to Fix pending
Updated by flacs almost 6 years ago
That fixed downloading but not the fact that we don't allow non-hex characters.
Updated by 8times9 almost 6 years ago
Oh okay, in that case someone might want to chance the title of this report to be more descriptive
Updated by Billiard26 almost 6 years ago
- Subject changed from Downloading Gecko codes is broken to Gecko code downloading fails to parse codes with XXs