Emulator Issues #11507
closed
DolphinQt: Common strings such as "Yes" and "No" aren't translated
0%
Description
Some common simple strings, such as as "Yes" and "No", aren't translated in DolphinQt. I guess this is because the strings only are used by code in Qt itself, not code that is in the Dolphin repo, and as such are not picked up by gettext and do not get translated on Transifex.
Quick way to reproduce: Clear out all Dolphin data or use portable.txt. Then you'll get the analytics question on first boot, with Yes and No buttons available for answering. (Since this also resets the language setting, you may want to just clear the analytics data instead if your system language is English.)
Updated by JosJuice over 5 years ago
tr calls for "Yes" and "No" happened to get added by 094bf0d, and translations for those two strings will therefore start showing up on Dolphin after two Transifex syncs. I'm not sure if there are any other common strings ("OK"? "Cancel"?) that we're missing.
Updated by JosJuice over 5 years ago
- Subject changed from DolphinQt: Common strings such as "Yes" and "No" aren't translated to DolphinQt: Strings from Qt itself are not added to the .pot file
- Milestone deleted (
Current)
We have "OK" and "Cancel" already, so I think it'll work fine for now. Unmarking as Current, but leaving open since we might want to investigate if there's a nice way to "pull" these strings directly from Qt (in case the netplay session browser stops containing the strings "Yes" and "No" or anything like that).
Updated by JosJuice over 4 years ago
- Subject changed from DolphinQt: Strings from Qt itself are not added to the .pot file to DolphinQt: Common strings such as "Yes" and "No" aren't translated
- Milestone set to Current
Actually, the Yes and No buttons still aren't getting translated despite the strings being in the .pot file.
I believe the relevant code in Qt is this code, which is specifying a context for the strings: https://code.woboq.org/qt5/qtbase/src/gui/kernel/qplatformtheme.cpp.html#_ZN14QPlatformTheme25defaultStandardButtonTextEi
Updated by JosJuice over 4 years ago
Getting contexts working is dependent on the firs two commits of https://github.com/dolphin-emu/dolphin/pull/8006.
Updated by JosJuice about 4 years ago
- Status changed from New to Work started
- Assignee set to JosJuice
Updated by JosJuice about 4 years ago
- Status changed from Work started to Fix pending
Actually, we didn't need context support at all for this. The thing that confused me was that the Qt string was "&Yes" whereas the string added in 094bf0d was "Yes". Regardless, fix pending in https://github.com/dolphin-emu/dolphin/pull/9159.
Updated by leoetlino about 4 years ago
- Status changed from Fix pending to Fixed
- Fixed in set to 5.0-12784