Project

General

Profile

Emulator Issues #11539

Dolphin fails to download NTSC_U GameTDB covers when they are organized under "EN".

Added by robross0606 9 months ago. Updated 6 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

  • Battle of Giants Dinosaurs Strike (Disc 0, Revision 0) SGXE41 (0001000053475845)
  • Top Shot: Dinosaur Hunter (Disc 0, Revision 0) R8XZ52 (000100005238585a)

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

  • 2d7699ffd8f8a041329a6e5ae633a86d
  • 727ebaa372ce058673f9fb3fe3ac050c

What's the problem? Describe what went wrong.

I have a couple games that Dolphin doesn't seem to pull back from Gametdb.com even though they are both USA region and the properties reports game IDs that I am able to look up manually on GameTDB and all the other metadata looks accurate.

What steps will reproduce the problem?

Simply open up Dolphin in grid mode and see a grey "x" on particular games instead of the proper cover image.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes 5.0-9458

Is the issue present in the latest stable version?

As far as I know, grid mode isn't available in stable version.

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

Seems to have been broken for these two games since the Grid feature was added in beta.

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

See attached.

What are your PC specifications? (CPU, GPU, Operating System, more)

Microsoft Windows 10 Pro Build 17134
Dell G3 3579 Laptop Core i7-9750H
24GB RAM
NVidia GTX 1050 Ti

Capture 1.PNG (133 KB) Capture 1.PNG robross0606, 01/26/2019 08:06 PM
Capture.PNG (168 KB) Capture.PNG robross0606, 01/26/2019 08:06 PM
7200
7201

History

#1 Updated by robross0606 9 months ago

Here are the locations of the data available for these games on Gametdb.com:
* https://www.gametdb.com/Wii/R8XZ52
* https://www.gametdb.com/Wii/SGXE41

#2 Updated by spycrab0 9 months ago

Have you tried deleting all files from your Cache/GameCovers folder in your Dolphin User directory?

Edit: You might wanna try deleting Cache/gamelist.cache too while you're at it.

#3 Updated by robross0606 9 months ago

I tried using the Purge Game List Cache from the View menu but I have not tried it manually yet. Which folder is it?

#4 Updated by robross0606 9 months ago

Okay, so I removed the /cache folder under Dolphin and that fixed one of the two. I guess the Purge... option on the menu is not the same as actually purging the folder manually. Even so, Top Shot: Dinosaur Hunter (R8XZ52) did not correct itself.

#5 Updated by JosJuice 9 months ago

The purge option in the menu is the same as deleting gamelist.cache.

#6 Updated by robross0606 9 months ago

I just checked the GameCovers subfolder and an image for R8XZ52 is not in there. Not sure why because it is accessible at:

https://www.gametdb.com/Wii/R8XZ52

My guess is that there is no high quality ("HQ") image available for that title. However, there is one for the low resolution and the cover art cache is low resolution anyway. It seems to only be looking for high resolution images and not the one available at:

https://art.gametdb.com/wii/cover/EN/R8XZ52.png

#7 Updated by robross0606 9 months ago

I was able to manually download that image and place it in the GameCovers cache folder which at least temporarily fixed the issue. Seems like a good idea for the cover art downloader to try for HQ images, but fail over to the low resolution image if an HQ one isn't available. Especially since the stored images are only thumbnail size anyway.

#8 Updated by Billiard26 6 months ago

  • Subject changed from Dolphin isn't pulling back cover images from Gametdb for all games. to Dolphin fails to download NTSC_U GameTDB covers when they are organized under "EN".

The problem is the database is inconsistent.

We expect the file to be named https://art.gametdb.com/wii/cover/US/R8XZ52.png (with "US") like almost every other NTSC_U title.
But gametdb has the cover located at https://art.gametdb.com/wii/cover/EN/R8XZ52.png (with "EN").

I'm not sure if this is intended and we need to support both cases or if GameTDB needs to be cleaned up.

#9 Updated by spycrab0 6 months ago

  • Assignee set to spycrab0
  • Status changed from New to Questionable

This is likely not a bug on our end and rather a misfiling on GameTDB's part.
I sent them a message to make sure.

It also seems to occur only for this game, since it didn't occur for any of the games in JMC's expansive NTSC-U library

#10 Updated by robross0606 6 months ago

spycrab0 wrote:

It also seems to occur only for this game, since it didn't occur for any of the games in JMC's expansive NTSC-U library

Since I listed two offending games in my original ticket, this is clearly not "only for [one] game". It may be limited in scope, but not that limited.

Are they listing games by their 2-character country code or by their 2-character language code? Is there API documentation that proves this is a "bug"? Or should the scraper be capable of checking both?

#11 Updated by robross0606 6 months ago

Just to prove the point, here is another game listed as "EN":

https://www.gametdb.com/Wii/SKTP78

I found this just by spot-checking on my fourth try.

#12 Updated by robross0606 6 months ago

Oh, I think I see what you're saying. It is specifically the combination of NTSC_U and EN that is a bug. EN is used all the time with PAL listings.

#13 Updated by spycrab0 6 months ago

I got a response from GameTDB:

Hi spycrab,

It was intentional, because X, Y and Z region codes were used by PAL games, at least at first, then some NTSC games were released with it. So it was a way to make it work with existing programs that used the database and relied on the ID to find the covers (E for Us, P, D, F, I, S, H, X, Y, Z for PAL). I hope it didn't cause too much trouble. If you'd like we could move all these to US, but it would break it for other programs. I could also try to find a solution to make them available in both EN and US. Let me know.

Here's the list of what we have set to NTSC, with covers set to EN:
'RUHX52','SLAZ78','RQPZ52','R38X78','RPWZ41','RU5Y4Q','STSZ4Q','SD2Y41','SMOX41','SG2YFS','R8XZ52','SFWZ69','SJDY41','SJDZ41','SEPZ41','STRX4Q','SKYY52','SDUX41','SSPY52','SK7XVZ','SC7Z52','SM8X52','DDWX18','RVYX52','SVXX52','SK8X52','SHVX78','SB9X78'

#14 Updated by Billiard26 6 months ago

I don't really get the response. I guess it's the way it is for historic reasons? :/

I'd let him know it would be nice for both EN and US to work I guess.. so we can rely on at least one of them to always exist.

#15 Updated by JosJuice 6 months ago

  • Status changed from Questionable to Accepted

I think I get it. Older programs were determining the region and thus whether to fetch EN or US based on the fourth character of the game ID rather than the actual region code. So I guess we just have to do the same thing if we want to be compatible with GameTDB's cover structure. But I don't know if we should entirely switch to using DiscIO::CountryCodeToRegion (or DiscIO::CountryCodeToCountry) for determining the region or if we should just hardcode in the cover code that X/Y/Z uses EN rather than US...

#16 Updated by JosJuice 6 months ago

On second thought, only using the fourth character of the game ID and not paying attention to the region code at all would break RLWW78. (Which way we do it would also matter for Korean GC games, but it seems GameTDB doesn't actually have any Korean GC covers, at least not for the games I checked.) So we should probably just hardcode X/Y/Z to use EN instead of US.

#17 Updated by spycrab0 6 months ago

  • Status changed from Accepted to Fixed

Should be fixed now.

It's done! It took a few changes on the site to make it easier to manage it but now all of the covers from the Toys R Us, Walmart and South American versions can be accessed with US or EN.
I moved all the pictures from EN to US and added symlinks to keep compatibility with existing programs that search for these in /EN/.
I hope that helps, please tell me if I missed anything.

Also available in: Atom PDF