Project

General

Profile

Emulator Issues #11589

Qt/macOS: QComboBox highlight color is wrong

Added by 8times9 about 2 years ago. Updated about 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Since updating the macOS builds to Qt 5.12 the highlight color for QComboBox dropdown menus is a light blue instead the expected blue.

Dolphin 5.0-9178.png (27.1 KB) Dolphin 5.0-9178.png Before 8times9, 02/25/2019 11:23 PM
Dolphin 5.0-9633.png (27.1 KB) Dolphin 5.0-9633.png After 8times9, 02/25/2019 11:23 PM
7272
7273

History

#1 Updated by 8times9 about 2 years ago

This also affects the right click menu (such as when right clicking on games in the games list).

However, the dropdown menu for controller profiles is the correct color.

#2 Updated by chargeflux about 2 years ago

This seems to be a Qt bug. I put together a sample app on macOS with just a QComboBox and the highlight color is wrong for that.

The controller profile is a QComboBox with the editable property enabled and probably explains why that has the correct highlight color since it is different from a regular QComboBox.

#3 Updated by 8times9 about 2 years ago

Interesting, do you know if it's reported on the Qt bug tracker yet? I tried searching but I couldn't find anything.

#4 Updated by chargeflux about 2 years ago

https://bugreports.qt.io/browse/QTBUG-70676?focusedCommentId=436075

Note the issue is marked as resolved but has not been actually fixed per linked comment.

Related: https://bugreports.qt.io/browse/QTBUG-28443?focusedCommentId=439198

Note linked comment mentioning it is present in 5.12 and I can confirm it is still present in 5.12.2

#5 Updated by 8times9 about 2 years ago

Thanks for the links, I left a comment on the first saying it's still present in 5.12.2

#6 Updated by chargeflux about 2 years ago

My apologies, I may have misled you with the first link :(. The issue is referring to QListView which is not the same as a QComboBox. From what I can tell, QListView has been fixed in Qt 5.12 (example is Qt Creator) but not QComboBox as of Qt 5.12.2. The comment is simply referring to the use of a deprecated method for QListView but still works as expected for QListView at this time.

The second link is the right one and comments suggests creating a new bug issue.

#7 Updated by chargeflux about 2 years ago

*because I thought the first link was referring to QComobBox but it wasn't.

Anyhow I filed a bug report on Qt and we can track that https://bugreports.qt.io/browse/QTBUG-75386. That being said, I suppose we won't see this change in Dolphin until they start using 5.12.x instead of 5.12.0 for macOS (based on BuildBot/builds uploaded to the website for macOS)

Also available in: Atom PDF