Emulator Issues #11639
EFB access in OpenGL doesn't span full screen
Super mario galaxy
Game ID? (right click the game in the game list, properties, info tab)
What's the problem? Describe what went wrong.
When shooting star bits in the middle of the screen with the OpenGL backend, the star bits will act normal. But when you shoot them near the edge of the screen they act like EFB access has been disabled. The same can be seen when looking at the sun at different angles in SMG. When looking straight at the sun, it acts normal but when the sun is at the top of the screen the effect doesn't work. Other backends are not affected by this.
Is the issue present in the latest development version?
Is the issue present in the latest stable version?
If the issue isn't present in the latest stable version, which is the first broken version?
The issue was introduced in 5.0-9737.Probably in this commit: https://github.com/dolphin-emu/dolphin/pull/7838/commits/6bc4bfd26af96de8642e75bbf644722c44baeb7b
Pretty sure the issue is because OpenGL uses lower left as origin and somewhere in the framebuffermanager, that isn't accounted for/not correctly used.
#3 Updated by Miksel12 about 2 years ago
Pretty sure this was the same issue which https://github.com/dolphin-emu/dolphin/pull/7934 fixed. Please update if the bug is still occurring.
The issue still occurs. Looking at the code I noticed how y is not flipped for OpenGL when the CreatePokeVertices function is called: https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/VideoCommon/FramebufferManager.cpp#L722
Maybe that's the issue?
#8 Updated by JosJuice about 2 years ago
- Fixed in set to 5.0-9861
- Status changed from Fix pending to Fixed