Project

General

Profile

Emulator Issues #11707

Qt: Align mapping buttons to the right

Added by Miksel12 almost 2 years ago. Updated 2 months ago.

Status:
Accepted
Priority:
Low
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Currently the mapping buttons and editable fields in the controller configuration screen are aligned to longest 'description' word. This creates different sizes of mapping buttons and editable fields. The mapping buttons have a max width making the difference not that noticeable but the editable fields don't have a max width making them stick out.

I think it would look much better if the fields and buttons were aligned to the right 'border', this would make the fields and buttons aligned to each other on the left as well as on the right side. This would also mean that the buttons and fields are aligned with the calibrate button.

See the attached pictures to see the difference between normal and being aligned on the right side by shrinking the window.

Normal.PNG (55.3 KB) Normal.PNG Under normal situation. Miksel12, 05/02/2019 07:47 PM
Aligned.PNG (45 KB) Aligned.PNG When shrunk. Miksel12, 05/02/2019 07:47 PM
New.png (48.4 KB) New.png Miksel12, 05/02/2019 07:58 PM
Align Right Wii Remote.PNG (43.9 KB) Align Right Wii Remote.PNG Wii remote mapping screen DaCodaDragon, 02/04/2021 12:15 AM
Align Right.PNG (49.5 KB) Align Right.PNG Controller Mapping Screen DaCodaDragon, 02/04/2021 12:15 AM
Sized.PNG (52.1 KB) Sized.PNG Controller mapping screen with uniform size DaCodaDragon, 02/04/2021 12:29 AM
7408
7409
7410
8192
8193
8194

Related issues

Related to Emulator - Emulator Issues #12007: Qt Controller UI bindings don't update when controller settings window is resizedNew

History

#1 Updated by Miksel12 almost 2 years ago

7410

I made a quick sketch.

#2 Updated by Silent over 1 year ago

Aligning them to right looks good to me. You PR'd a fix to make fields and buttons uniform in size a while ago, but I do think aligning them to right would potentially make it look better.

#3 Updated by Miksel12 over 1 year ago

I tried to align the buttons to the right while using Qformlayout but that didn't work or look great. Qgridlayout did look great but it lacks addRow/insertRow so code wise it looks kinda ugly but I'm not a Qt expert.

#4 Updated by Billiard26 over 1 year ago

  • Issue type changed from Bug to Feature request
  • Priority changed from Normal to Low
  • Status changed from New to Accepted

#5 Updated by Billiard26 about 1 year ago

  • Related to Emulator Issues #12007: Qt Controller UI bindings don't update when controller settings window is resized added

#6 Updated by DaCodaDragon 3 months ago

8192
8193
8194

Silent wrote:

Aligning them to right looks good to me. You PR'd a fix to make fields and buttons uniform in size a while ago, but I do think aligning them to right would potentially make it look better.

I am not entirely sure how I feel about this one. I've two examples set up where the windows are quite stretched out. Things look super spaced out from eachother.
Wii remote mapping screen
Controller Mapping Screen

I could try a few different things. I was rather thinking about making the fields and buttons the same size.
Controller mapping screen with uniform size

I feel this looks a lot more pleasing to the eye having things more lined up with eachother. It might be too cluttered for some though. We could potentially add more spacing between the text and the widget but still make fields and buttons uniformly sized?

#7 Updated by Miksel12 2 months ago

Like I said a year ago, mappings currently use Qformlayout which is quite inflexible. A layout like Qgridlayout is much more flexible.

Also available in: Atom PDF