Emulator Issues #11707
closedQt: Align mapping buttons to the right
0%
Description
Currently the mapping buttons and editable fields in the controller configuration screen are aligned to longest 'description' word. This creates different sizes of mapping buttons and editable fields. The mapping buttons have a max width making the difference not that noticeable but the editable fields don't have a max width making them stick out.
I think it would look much better if the fields and buttons were aligned to the right 'border', this would make the fields and buttons aligned to each other on the left as well as on the right side. This would also mean that the buttons and fields are aligned with the calibrate button.
See the attached pictures to see the difference between normal and being aligned on the right side by shrinking the window.
Files
Updated by Silent over 5 years ago
Aligning them to right looks good to me. You PR'd a fix to make fields and buttons uniform in size a while ago, but I do think aligning them to right would potentially make it look better.
Updated by Miksel12 over 5 years ago
I tried to align the buttons to the right while using Qformlayout but that didn't work or look great. Qgridlayout did look great but it lacks addRow/insertRow so code wise it looks kinda ugly but I'm not a Qt expert.
Updated by Billiard26 about 5 years ago
- Status changed from New to Accepted
- Priority changed from Normal to Low
- Issue type changed from Bug to Feature request
Updated by Billiard26 almost 5 years ago
- Related to Emulator Issues #12007: Qt Controller UI bindings don't update when controller settings window is resized added
Updated by DaCodaDragon almost 4 years ago
- File Align Right Wii Remote.PNG Align Right Wii Remote.PNG added
- File Align Right.PNG Align Right.PNG added
- File Sized.PNG Sized.PNG added
Silent wrote:
Aligning them to right looks good to me. You PR'd a fix to make fields and buttons uniform in size a while ago, but I do think aligning them to right would potentially make it look better.
I am not entirely sure how I feel about this one. I've two examples set up where the windows are quite stretched out. Things look super spaced out from eachother.
I could try a few different things. I was rather thinking about making the fields and buttons the same size.
I feel this looks a lot more pleasing to the eye having things more lined up with eachother. It might be too cluttered for some though. We could potentially add more spacing between the text and the widget but still make fields and buttons uniformly sized?
Updated by Miksel12 almost 4 years ago
Like I said a year ago, mappings currently use Qformlayout which is quite inflexible. A layout like Qgridlayout is much more flexible.
Updated by Miksel12 about 2 years ago
This can be marked as fixed: https://github.com/dolphin-emu/dolphin/pull/11271
Updated by JosJuice about 2 years ago
- Status changed from Accepted to Fixed
- Fixed in set to 5.0-17844