Project

General

Profile

Emulator Issues #11715

Wii savefile export broken

Added by aetios 9 months ago. Updated 9 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-7478
Fixed in:
5.0-10161

Description

Game Name?

[N/A] - Tested with Metroid Prime Trilogy (PAL)

Game ID? (right click the game in the game list, Properties, Info tab)

[N/A] - Tested with R3MP01

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

[N/A] - Tested with 735c0d0c16177e3294f5e0faf7a69571

What's the problem? Describe what went wrong.

[Exported Wii save files will give an error on import on the Wii, with the message 'The data may not have been copied'/'The data may not have been moved' (depending on the selected option).]

What steps will reproduce the problem?

[Right-click a game in the Dolphin file browser on 5.0-10151
Choose Export Wii Save (Experimental) and put the files somewhere
Copy the created files onto a Wii SD card and put the card in the Wii
On the Wii, navigate to the save file manager and select the SD card
Select the save file in question and select Move or Copy
The dialog will show an error notice after a brief moment.]

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

[Yes, 5.0-10151]

Is the issue present in the latest stable version?

[Probably not]

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

[5.0-7459]

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

[N/A]

What are your PC specifications? (CPU, GPU, Operating System, more)

[CPU: Intel i5-6600
GPU: AMD Sapphire R9 Fury
RAM: 16G DDR4
OS: Arch Linux]

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

[Anything else here]

mpsaves.zip (348 KB) mpsaves.zip aetios, 05/05/2019 08:30 PM

History

#1 Updated by aetios 9 months ago

Bisected commit is actually a2ffe010f3f6d5903400f6e09dbeec632c3f0c40.

For reference here is my git bisect log:

>> git bisect log
git bisect start
# bad: [4fdd403562f73f082438194ed173ee080c6d2c45] Merge pull request #8078 from JosJuice/fallthrough
git bisect bad 4fdd403562f73f082438194ed173ee080c6d2c45
# good: [10d230a512b99aee66f7343481ed13d83557de22] Merge pull request #6784 from leoetlino/file-creation
git bisect good 10d230a512b99aee66f7343481ed13d83557de22
# bad: [c49eb2d24975dcbbdb916e19bdb9c01068936884] Merge pull request #7398 from Techjar/emu-speed-skip-vsync
git bisect bad c49eb2d24975dcbbdb916e19bdb9c01068936884
# bad: [5e0da225ee7a4e8e0956e38f4ee52109444d2b5b] Merge pull request #7068 from lioncash/const
git bisect bad 5e0da225ee7a4e8e0956e38f4ee52109444d2b5b
# bad: [9eb3bce5201757d31729227a4a458938311f6ee3] Qt/MappingWindow: Make sure widgets don't need scrolling by default
git bisect bad 9eb3bce5201757d31729227a4a458938311f6ee3
# bad: [f8e5e7126c4ae07e06d12dcce7f4e0855c7f9db9] Merge pull request #6849 from leoetlino/oops
git bisect bad f8e5e7126c4ae07e06d12dcce7f4e0855c7f9db9
# good: [e78235943eb5ada474f7ec5383f28521feeaf9a4] Merge pull request #6823 from spycrab/qt_reset_hotkey
git bisect good e78235943eb5ada474f7ec5383f28521feeaf9a4
# good: [99dff10d43895296a6e48d48467e1e8564d65a6b] Merge pull request #6837 from spycrab/qt_position
git bisect good 99dff10d43895296a6e48d48467e1e8564d65a6b
# good: [799e4154beaf447aaa1dee6838846b9daf9fe7d9] PatchesWidget: Convert Core and UICommon includes into forward declarations                                                                                                                
git bisect good 799e4154beaf447aaa1dee6838846b9daf9fe7d9
# good: [74d561085cf911bbad6949532b46dbd92634c63f] Merge pull request #6848 from lioncash/guard
git bisect good 74d561085cf911bbad6949532b46dbd92634c63f
# bad: [3fbfa4335ef1705a4fa837cda0ed217bfb927521] WiiSave: Fix out-of-bounds read
git bisect bad 3fbfa4335ef1705a4fa837cda0ed217bfb927521
# bad: [a2ffe010f3f6d5903400f6e09dbeec632c3f0c40] WiiSave: Reuse IOSC::Sign for signing
git bisect bad a2ffe010f3f6d5903400f6e09dbeec632c3f0c40
# good: [07caac1d23db7b84f477b2e793a5163fab7425e4] WiiSave: Reuse IOSC for AES decryption/encryption
git bisect good 07caac1d23db7b84f477b2e793a5163fab7425e4
# first bad commit: [a2ffe010f3f6d5903400f6e09dbeec632c3f0c40] WiiSave: Reuse IOSC::Sign for signing

Also attached: An archive with a working and a broken savefile.

#2 Updated by leoetlino 9 months ago

  • Regression start set to 5.0-7478
  • Regression changed from No to Yes
  • Status changed from New to Fix pending

#3 Updated by JosJuice 9 months ago

  • Fixed in set to 5.0-10161
  • Status changed from Fix pending to Fixed

Also available in: Atom PDF