Project

General

Profile

Emulator Issues #11722

Dolphin crashes when closing a Wii game with dual core disabled when using Cubeb/WASAPI backend

Added by PPLToast 7 months ago. Updated 7 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-10198

Description

I don't really get it.

Here's a stack trace from both cubeb and wasapi if it helps.

cubeb.png (111 KB) cubeb.png PPLToast, 05/09/2019 10:01 AM
wasapi.png (98.5 KB) wasapi.png PPLToast, 05/09/2019 10:01 AM
7418
7420

History

#1 Updated by leoetlino 7 months ago

Could you attach log files please? (with the AUDIO log type enabled)

#2 Updated by leoetlino 7 months ago

  • Status changed from New to Accepted

There's a race condition in Dolphin that can cause the audio stream to be stopped by two different threads at the same time. Let me see how to fix that...

#3 Updated by PPLToast 7 months ago

I would, but it seems setting the audio emulator log type makes it really resilient if not near impossible to crashing somehow.

#4 Updated by leoetlino 7 months ago

Could you test PR 8095 and see if it fixes this issue?

#5 Updated by PPLToast 7 months ago

Sorry, I went to sleep right after I posted 😬

From some testing, it does indeed seem to be fixed! Huge thanks leo, was kinda afraid this was gonna be difficult to fix due to how random it was...

#6 Updated by Stenzek 7 months ago

  • Fixed in set to 5.0-10198
  • Status changed from Accepted to Fixed

Also available in: Atom PDF