Project

General

Profile

Actions
Copy link

Emulator Issues #11767

closed

Race condition in AppLinkActivity (Android TV channels)

Added by JosJuice over 5 years ago. Updated about 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Android
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-10874

Description

AppLinkActivity calls GameFileCacheService.startLoad: https://github.com/dolphin-emu/dolphin/blob/1cb0900a10b3e71fedca8ab74278b2d49be12089/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/AppLinkActivity.java#L96

But then it does not wait for GameFileCacheService to finish before trying to use the result: https://github.com/dolphin-emu/dolphin/blob/1cb0900a10b3e71fedca8ab74278b2d49be12089/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/AppLinkActivity.java#L75

I haven't tested it in practice since I don't have an Android TV device, but this should mean that games might fail to launch occasionally if launched from a channel.

Actions
Copy link
 #1

Updated by JosJuice over 5 years ago

  • Status changed from New to Fix pending
Actions
Copy link
 #2

Updated by JosJuice about 5 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-10874
Actions
Copy link

Also available in: Atom PDF