Project

General

Profile

Actions

Emulator Issues #11820

closed

Memory Card Manager may not correctly display game titles/comments if they're not in the first block of data.

Added by AdmiralCurtiss over 4 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-11223

Description

Seems like no game actually does this since it would probably have come up otherwise, but the GC BIOS gives different results to our card manager here.

Attached are two handcrafted memory cards that exhibit this incorrect behavior.

The comment-physical-logical-block-test one shows that Dolphin does not correctly follow save blocks and assumes a static offset from the physical on-card location of the first save block:

The comment-boundary-cross-test one shows that although yagcd claims that "The two strings (64 bytes) must fit within one block (8192 bytes), they are not allowed to cross sector boundaries.", this appears to be wrong, as the BIOS untangles this just fine.

I'll PR a fix for this later probably, but just wanted to note this somewhere.


Files

physical-logical-dolphin.png (3.45 KB) physical-logical-dolphin.png AdmiralCurtiss, 08/06/2019 07:02 PM
physical-logical-bios.png (82.7 KB) physical-logical-bios.png AdmiralCurtiss, 08/06/2019 07:02 PM
boundary-cross-dolphin.png (3.45 KB) boundary-cross-dolphin.png AdmiralCurtiss, 08/06/2019 07:02 PM
boundary-cross-bios.png (80.4 KB) boundary-cross-bios.png AdmiralCurtiss, 08/06/2019 07:02 PM
comment-boundary-cross-test.7z (526 Bytes) comment-boundary-cross-test.7z AdmiralCurtiss, 08/06/2019 07:03 PM
comment-physical-logical-block-test.7z (521 Bytes) comment-physical-logical-block-test.7z AdmiralCurtiss, 08/06/2019 07:03 PM

Related issues 1 (0 open1 closed)

Related to Emulator - Emulator Issues #10600: Memcard Manager crashes with certain memory card layoutsFixed

Actions
Actions #1

Updated by JosJuice over 4 years ago

Actions #3

Updated by JosJuice over 4 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-11223
Actions

Also available in: Atom PDF