Project

General

Profile

Actions

Emulator Issues #11846

closed

GCMemcardManager : icon drawing takes to much cpu time

Added by DacoTaco over 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
Yes
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-11229

Description

Game Name?

Game ID? (right click the game in the game list, Properties, Info tab)
\

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)
\

What's the problem? Describe what went wrong.
opening a larger memory card with quite a few saves will cause dolphin to take to much cpu time ( +/- 25% of my 4th gen I5 ). this results in the window responding slowly or not at all sometimes.
this is the result of the DrawIcons timer keeps on triggering and taking to much time.

What steps will reproduce the problem?
open the following raw in the manager : https://upload.dacotaco.com/MemoryCardA_EUR_OWN SHIT.EUR.raw and try and use the window or resize it.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
yes, i was using 5.0-10908
commit : https://github.com/dolphin-emu/dolphin/commit/a9745400ec5cea7e55d94955afbdc44d1a4982d1

Is the issue present in the latest stable version?
no, as this is an issue of the new QT window.

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

https://github.com/dolphin-emu/dolphin/commit/13ba24c5a6795532c8893eccf2a21ae95682e1b7#diff-d51aaa3a18e35b28b51830518a2c7d44
^last commit i could quickly find of the file's log. didn't look before the rename.

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

[Attach any fifologs if possible, write a description of fifologs and screenshots here to assist people unfamiliar with the game.]

What are your PC specifications? (CPU, GPU, Operating System, more)

i5-4690 , 3.5Ghz

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

see raw link above.
i'll make a PR of some progress of the issue later. just gonna check if there isn't any quick bug i can smash while im busy


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #11847: GCMemcardManager : icon drawing takes to much cpu timeDuplicate

Actions
Actions #2

Updated by Helios over 4 years ago

  • Status changed from New to Fix pending
  • Relates to usability changed from No to Yes
Actions #3

Updated by JosJuice over 4 years ago

Actions #4

Updated by Miksel12 over 3 years ago

The fix has been merged.

Actions #5

Updated by JosJuice over 3 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-11229
Actions

Also available in: Atom PDF