Emulator Issues #1186
closedScreenshots are clipped at the top
0%
Description
What steps will reproduce the problem?
- Run any game with a custom solution (in my case, Starfox Assault on
1680x1050) - Hit F9 to take a screenshot
What is the expected output? What do you see instead?
Expected is a screenshot with 1680x1050px that contains the same image i
see on screen.
Instead I get a 1680x1050px image that has 1680x980 filled with the screen,
the bottom is black.
What version of the product are you using? On what operating system?
r3879 JitIL Build with OGL Plugin on WinXP SP2 32-bit
Please provide any additional information below.
I modified Render.cpp to tell me the size of the XFB:
Index: I:/Dolphin/svn/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp¶
--- I:/Dolphin/svn/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp (revision
3879)
+++ I:/Dolphin/svn/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp (working copy)
@@ -893,7 +893,7 @@
glFramebufferTexture2DEXT(GL_READ_FRAMEBUFFER_EXT,
GL_COLOR_ATTACHMENT0_EXT, GL_TEXTURE_RECTANGLE_ARB, xfbSource->texture, 0);
s_criticalScreenshot.Enter();
-
// Save screenshot
-
// Save screenshot SaveRenderTarget(s_sScreenshotName.c_str(),
xfbSource->sourceRc.GetWidth(), xfbSource->sourceRc.GetHeight(), yOffset);
// Reset settings
s_sScreenshotName = "";
@@ -902,6 +902,7 @@
glFramebufferTexture2DEXT(GL_READ_FRAMEBUFFER_EXT,
GL_COLOR_ATTACHMENT0_EXT, GL_TEXTURE_RECTANGLE_ARB, 0, 0);
glBindFramebufferEXT(GL_READ_FRAMEBUFFER_EXT,
s_framebufferManager.GetEFBFramebuffer());
-
OSD::AddMessage(StringFromFormat("xfbSource: %dx%d; yOffset: %d",
xfbSource->sourceRc.GetWidth(), xfbSource->sourceRc.GetHeight(),
yOffset).c_str(), 2000);
}
// Frame dumps are handled a little differently in Windows
xfbSource is 1680x980, yOffset is 0. I'd expect xfbSource to be 1680x1050
or the likes, but for some reason the top 70px are clipped off.
See this image as example:
[URL=http://s385.photobucket.com/albums/oo295/BhaaLseN/dolphin/?action=view¤t=GF7E01-7.jpg][IMG]http://i385.photobucket.com/albums/oo295/BhaaLseN/dolphin/th_GF7E01-7.jpg[/IMG][/URL]
The top part is missing (where the Hit Counter usually sits), while the
bottom part is black.
Surprisingly, the black bar at the bottom is about 174px in height, which
amounts to 1154px if i add it to the 980px from earlier.