Emulator Issues #11899: Text-field based settings under emulated Wii Remote configuration won't save and will always revert to default. - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #11899

closed

Text-field based settings under emulated Wii Remote configuration won't save and will always revert to default.

Added by Skyy over 4 years ago. Updated over 4 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

Billiard26

% Done:

Operating system:

N/A

Issue type:

Bug

Milestone:

Regression:

Yes

Relates to usability:

Relates to performance:

Easy:

Relates to maintainability:

Regression start:

5.0-11046

Fixed in:

5.0-11430

Description

Game Name?

[N/A]

Game ID? (right click the game in the game list, Properties, Info tab)

[N/A]

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

[N/A]

What's the problem? Describe what went wrong.

When configuring an emulated Wii Remote changing any of the text-field based settings such as changing the reported battery-level won't be saved and they will revert back to the default settings. Any other settings based on check-boxes or actual bindings will save normally. Running Dolphin with administrator rights makes no difference.

What steps will reproduce the problem?

Open the emulated Wii Remote configuration window and change any of the text-field based settings, then close the window. Upon reopening the configuration window the settings will be reset to default.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, 5.0-11238

Is the issue present in the latest stable version?

Sorry haven't had the time to test but can do if requested.

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

Sorry haven't had the time to go through that but can do if requested.

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

[N/A]

What are your PC specifications? (CPU, GPU, Operating System, more)

OS: Windows 10 1903 64bit

Dolphin is installed on a separate HDD running in non Portable Mode with the settings directory being the default one in Documents, there are no (obvious) permission issues.

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

[N/A]

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Billiard26 over 4 years ago

I can't reproduce this.

Actions

Copy link

Updated by Skyy over 4 years ago

Billiard26 wrote:

I can't reproduce this.

Hmm anyhow I can help to further narrow the issue down?

Actions

Copy link

Updated by Billiard26 over 4 years ago

Related to Emulator Issues #11914: Controller profiles don't save deadzones nor "shaking" options added

Actions

Copy link

Updated by Billiard26 over 4 years ago

Has duplicate Emulator Issues #11938: Controls partially not saving. added

Actions

Copy link

Updated by Lootwig over 4 years ago

Miksel12

5.0-11046 is the culprit: https://github.com/dolphin-emu/dolphin/pull/8415

Actions

Copy link

Updated by Skyy over 4 years ago

Lootwig wrote:

Miksel12

5.0-11046 is the culprit: https://github.com/dolphin-emu/dolphin/pull/8415

I can confirm it's fixed on my end, I just updated to the latest build and tested it again, it saves properly now thanks!

Actions

Copy link

Updated by Lootwig over 4 years ago

The latest build is 5.0-11409 and it's still not working for me.

Actions

Copy link

Updated by Billiard26 over 4 years ago

Would someone (who can reproduce this issue) please confirm my suspicion that in prior to 5.0-11046 (before the regression) the mentioned settings do not properly load decimal values?

E.g. Does saving a "Battery Level" of 80.5 load as just 80?

Actions

Copy link

Updated by Lootwig over 4 years ago

When i type in 80.5 and press load it returns to 95

Actions

Copy link

#10

Updated by Billiard26 over 4 years ago

@Lootwig

In which version?

Actions

Copy link

#11

Updated by Lootwig over 4 years ago

5.0-11409 as i already said.

Actions

Copy link

#12

Updated by Billiard26 over 4 years ago

@Lootwig

I am already aware of the behavior you are getting post regression.

Please test a version "prior to 5.0-11046 (before the regression)".

Thank you.

Actions

Copy link

#13

Updated by Lootwig over 4 years ago

Oh sorry i copied the wrong number. its 5.0-11409 not 5.0-11046

Actions

Copy link

#14

Updated by Billiard26 over 4 years ago

Please test a version "prior to 5.0-11046 (before the regression)".

Actions

Copy link

#15

Updated by Lootwig over 4 years ago

With 5.0-11044 it works. Version 11046 and up it does not work.

Actions

Copy link

#16

Updated by Billiard26 over 4 years ago

Please be more clear in your response.

When testing 5.0-11044 does 80.5 load as 80.5 or does it load as just 80?

Actions

Copy link

#17

Updated by Lootwig over 4 years ago

I have to test this BUT wehen i enter 10% deadzone save and than load the 10% are applied.In the newer versions this does not work.

Actions

Copy link

#18

Updated by Lootwig over 4 years ago

So to be absolutely clear.

Version 5.0- 11044

Saving 10% Deadzone > loading = 10% Deadzone
Saving Batterie 80,5% > loading = 80% Batterie

Since Version 5.0- 11046

Saving 10% Deadzone > loading = 0% Deadzone (Default)
Saving Batterie 80,5% > loading 95% Batterie (Default)

Actions

Copy link

#19

Updated by Billiard26 over 4 years ago

Thank you.

FYI, this is a locale issue. We improperly handle non-"." decimal separators.

As I suspected, loading was already broken and ignored numbers after the separator.

I broke it in a different way to instead completely fail with an unexpected separator.

Actions

Copy link

#20

Updated by Billiard26 over 4 years ago

Status changed from New to Accepted
Assignee set to Billiard26
Regression changed from No to Yes
Regression start set to 5.0-11046

Actions

Copy link

#21

Updated by Billiard26 over 4 years ago

Status changed from Accepted to Fix pending

@ Lootwig

If possible please see if this fixes the issue on your end: https://github.com/dolphin-emu/dolphin/pull/8541

Actions

Copy link

#22

Updated by Lootwig over 4 years ago

I don't know what to do with that link. I'm not a programmer. I'm just a guy who likes to play around with emulators ^^. So what file do i have to open to change those strings ? And can i edit them with Notepad++ ?

Actions

Copy link

#23