Emulator Issues #11920: 5.0-11297 and newer freeze upon creating memory breakpoint when using DSP LLE on same thread - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #11920

closed

5.0-11297 and newer freeze upon creating memory breakpoint when using DSP LLE on same thread

Added by Minty_Meeo over 4 years ago. Updated about 4 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

% Done:

Operating system:

Issue type:

Bug

Milestone:

Current

Regression:

Yes

Relates to usability:

Relates to performance:

Easy:

Relates to maintainability:

Regression start:

5.0-11297

Fixed in:

5.0-11836

Description

What's the problem? Describe what went wrong.

Creating a Memory Breakpoint freezes Dolphin when the DSP Emulation Engine is not in DSP HLE mode.
The commit that causes this (https://github.com/dolphin-emu/dolphin/commit/e33acc07f9b98b863f70483bac491f2d85601b4a) changed the behavior of the DSP thread when pausing emulation, so obviously that has something to do with it.

What steps will reproduce the problem?

Set the DSP Emulation Engine to DSP LLE Recompiler or DSP LLE Interpreter
Attempt to make a memory breakpoint

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes (5.0-11337)

Is the issue present in the latest stable version?

No. It first appeared in 5.0-11297.

What are your PC specifications? (CPU, GPU, Operating System, more)

Operating System: Windows 7 Ultimate x64 (6.1, Build 7601)
Processor/CPU: AMD Athlon II X2 255 Processor (2 CPUs), ~3.1GHz
Video Card/GPU: NVIDIA GeForce GTX 550
Memory/RAM: Mixed DDR2. Two Samsung 1GB. Two ULTRA(?) 1GB.

Actions

Copy link

Updated by JosJuice over 4 years ago

Subject changed from 5.0-11297 and beyond have debugger bug to 5.0-11297 and newer freeze upon creating memory breakpoint when using DSP LLE on thread
Milestone set to Current
Regression changed from No to Yes
Regression start set to 5.0-11297

Actions

Copy link

Updated by pokechu22 about 4 years ago

I'm getting something similar, except only DSP LLE interpreter is affected (and DSP LLE interpreter does not use a thread). It also affects anything that calls DSPLLE::PauseAndLock (which mainly comes from calls to Core::RunAsCPUThread), not just the memory breakpoint. For instance, changing any setting (including audio volume or Show FPS), attempting to change discs (unrelated to #11503), or opening the graphics settings window for the first time.

(I am able to reproduce with DSP LLE recompiler when in determinism mode (tested by recording input), since determinism mode disables the DSP LLE thread.)

Actions

Copy link

Updated by JosJuice about 4 years ago

Status changed from New to Fix pending

https://github.com/dolphin-emu/dolphin/pull/8736

Actions

Copy link

Updated by JosJuice about 4 years ago

Subject changed from 5.0-11297 and newer freeze upon creating memory breakpoint when using DSP LLE on thread to 5.0-11297 and newer freeze upon creating memory breakpoint when using DSP LLE not on same thread
Operating system deleted (~~N/A~~)

Actions

Copy link

Updated by JosJuice about 4 years ago

Subject changed from 5.0-11297 and newer freeze upon creating memory breakpoint when using DSP LLE not on same thread to 5.0-11297 and newer freeze upon creating memory breakpoint when using DSP LLE on same thread

Actions

Copy link