Project

General

Profile

Actions

Emulator Issues #11995

closed

Feature Request: Add Support for .map files from Nvidia Shield releases

Added by leo60228 almost 5 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-15011

Description

Game Name?

Super Mario Galaxy

Game ID? (right click the game in the game list, Properties, Info tab)

RMGJ01

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

de205dd5e379f5bd2e0fcea8cae9497b

What's the problem? Describe what went wrong.

All of the Chinese-exclusive Nvidia Shield releases of Wii games (except New Super Mario Bros. Wii) include .map files for Japan, Korea, and China (labeled as US), even if the original releases did not. One for the Japanese release of Super Mario Galaxy is at https://gist.github.com/leo60228/ee9ac30198703e7a418ad0f1adeca883. Dolphin has difficulty parsing these files. For example, the added field before the symbol name, which is always " 4" or "64" (alignment?) is included in the symbol name. Even when this is removed, about 90% of symbols include substrings of the address in their names, with no clear pattern.

What steps will reproduce the problem?

  1. Download https://gist.github.com/leo60228/ee9ac30198703e7a418ad0f1adeca883
  2. Launch Japanese Super Mario Galaxy
  3. Load above symbol map
  4. Scroll through symbol list

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

I'm on Linux, so I can't use official binaries. https://github.com/leo60228/dolphin/tree/dev-dolphin-change-disc experiences this problem.

Is the issue present in the latest stable version?

Untested

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

N/A

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

N/A

What are your PC specifications? (CPU, GPU, Operating System, more)

  • CPU: Ryzen 5 3600
  • GPU: RX 5700 (Mesa 20.0.0, ACO shader compiler)
  • OS: NixOS unstable

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

https://gist.github.com/leo60228/ee9ac30198703e7a418ad0f1adeca883

Actions #1

Updated by leo60228 almost 5 years ago

I can't figure out how to open the debugger on 5.0...

Actions #2

Updated by sepalani over 4 years ago

You can enable the debugger UI in Options > Configuration, then click on the Interface tab and tick "Show Debugging UI".

This map can be loaded properly if you add under the .text line:

  Starting        Virtual  File
  address  Size   address  offset
  ---------------------------------

The current heuristic to detect the symbol map file format is the issue here.

@leo60228
Does the other map files you have look like that (i.e. the column header seems missing) or is it the only one like this.

Actions #3

Updated by JMC4789 over 3 years ago

  • Subject changed from Dolphin cannot parse .map files from Nvidia Shield releases to Feature Request: Add Support for .map files from Nvidia Shield releases
  • Status changed from New to Accepted
  • Priority changed from Normal to Low
Actions #4

Updated by sepalani over 3 years ago

Actions #5

Updated by leoetlino over 3 years ago

  • Status changed from Accepted to Fixed
  • Fixed in set to 5.0-15011
Actions

Also available in: Atom PDF