Project

General

Profile

Emulator Issues #12086

Dolphin fails to build on MSVC 14.26

Added by filoppi 2 months ago. Updated 25 days ago.

Status:
Accepted
Priority:
High
Assignee:
-
% Done:

0%

Operating system:
Windows
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
Yes
Regression start:
Fixed in:

Description

Dolphin fails to build on Visual Studio 2019 16.6.0 with it's default MSVC version. Still, it's possible to download and force building with MSVC 14.25, which works.
The problem seems to mainly be the removal of std::result_of and std::result_of_t, which is used by Dolphin itself and Qt 5.14.1 (already fixed in 5.14.2). I didn't check all the errors as there were hundreds, but it seemed like that was the only one.

The MSVC team already opened a bug on this (https://bugs.dolphin-emu.org/issues/11970), but they only had problems with fmt; I really don't understand how they did not have problems with all the other cases of std::result_of around the project. I've tried to add the preprocessor definitions they specified but it still didn't build.

History

#1 Updated by JosJuice 2 months ago

  • Relates to maintainability changed from No to Yes
  • Milestone set to Current
  • Operating system Windows added
  • Operating system deleted (N/A)

#2 Updated by filoppi about 2 months ago

This is still broken the final release of VS 16.6.0.

#3 Updated by JosJuice 25 days ago

  • Priority changed from Normal to High
  • Status changed from New to Accepted

The std::result_of usage in Dolphin itself was removed in https://github.com/dolphin-emu/dolphin/pull/8841. The Qt submodule still needs to be updated.

Also available in: Atom PDF