Project

General

Profile

Emulator Issues #12151

Windows updater does not properly request administrator access

Added by superluig164 4 months ago. Updated 4 months ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Windows
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Currently, the updater does two undesirable things:
When Dolphin is installed in a protected folder (such as Program Files) the Updater does not ask for administrator privileges before attempting to run, and subsequently fails.

When the Updater fails, it fails silently, with no error or warning that the update did not succeed.

I propose that either the Updater ask for permission when in a protected folder, or at least inform the user to run Dolphin as administrator so that when it launches the updater, it also runs elevated, allowing it to succeed.

History

#1 Updated by delroth 4 months ago

We already do that though? For a very long time too. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Main.cpp#L76

You did not provide any information about which Dolphin version you're using.

#2 Updated by superluig164 4 months ago

delroth wrote:

We already do that though? For a very long time too. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Main.cpp#L76

You did not provide any information about which Dolphin version you're using.

I'm using 5.0-12106. I've had Dolphin in Program files since 5.0 stable. Never once has it asked for administrator permission before launching the updater, instead failing to update silently. I must launch Dolphin with administrator privileges first, to allow it to create a child process which is allowed to modify the protected folder.

#3 Updated by delroth 4 months ago

  • Status changed from New to Accepted
  • Subject changed from [Feature Request] Make the Updater request administrator permissions or issue a warning when required to Windows updater does not properly request administrator access
  • Operating system Windows added
  • Operating system deleted (N/A)

I just tested removing my permissions on my Dolphin folder and indeed we don't seem to be properly asking for administrator access. Haven't debugged why exactly, but we have code to try and do that, and it seems to not do what we expect.

#4 Updated by superluig164 4 months ago

delroth wrote:

I just tested removing my permissions on my Dolphin folder and indeed we don't seem to be properly asking for administrator access. Haven't debugged why exactly, but we have code to try and do that, and it seems to not do what we expect.

Awesome, thanks. Can't wait to see this working properly!

#5 Updated by JosJuice 4 months ago

  • Milestone set to Current

Setting as Current, since stable releases frequently are installed to Program Files.

Also available in: Atom PDF