Emulator Issues #12162
closed
Dolphin 5.0-11997 (PR #8789) causes another remarkable fps slowdown in every game
0%
Description
Game Name?
again every game (tested mostly Super Mario Galaxy - RMGP01)
Game ID? (right click the game in the game list, Properties, Info tab)
again every game (tested mostly Super Mario Galaxy - RMGP01)
MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)
1d5366a8ee435132eab67e6f48352e3d
What's the problem? Describe what went wrong.
Dolphin 5.0-11997 (PR #8789) https://github.com/dolphin-emu/dolphin/pull/8789 causes a massive fps slowdown in every game (see in the images below: for example SMG has a slowdown of about 20%, from 220% speed to 200%)
What steps will reproduce the problem?
compare game speed between revision 5.0-11995 and 5.0-11997
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
yes 5.0-12151
Is the issue present in the latest stable version?
No
If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
5.0-11997
If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer
I will provide the fifologs in a short while
What are your PC specifications? (CPU, GPU, Operating System, more)
Windows 10
Intel i7 7700
Nvidia RTX 2060 super
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
In my eternal "war" against regressions, I found out that latest Dolphin revisions are not only slowed down by 5.0-12036, but also by 5.0-11997 as well...
Files
Updated by JosJuice over 4 years ago
- Status changed from New to Questionable
- Regression changed from No to Yes
- Relates to performance changed from No to Yes
- Regression start set to 5.0-11997
Not sure why that change would cause a performance regression, unless maybe the change in CommandProcessor.cpp is giving the compiler trouble optimizing...
Updated by markwest76 over 4 years ago
Must be that, anyway the images speak for themselves...
Here are the fifologs (I've recorded the game "Cursed Mountain" because SMG exceeds 200% speed)
https://www.dropbox.com/s/2zixx7xy986omou/CursedMountain_fifolog_11995.dff?dl=0
https://www.dropbox.com/s/4tarv64s176oy73/CursedMountain_fifolog_11997.dff?dl=0
Updated by markwest76 over 4 years ago
Not 100% sure because there was/is still another commit that caused a slowdown (so it's not easy to compare fps after that), but anyway I do think that PR #8898 has fixed this issue...
Updated by JosJuice over 4 years ago
- Status changed from Questionable to Fixed
- Fixed in set to 5.0-12210
That PR reverts the change in CommandProcessor.cpp, so I guess the bisect actually was correct after all. Weird why the change would affect the performance that much, though.
Updated by markwest76 over 4 years ago
"Interesting" to notice that PR8912 https://github.com/dolphin-emu/dolphin/pull/8912 (aka Dolphin 5.0-12237) has brought back a similar slow down, but fortunately only for "Tales of Monkey Island" (all my other games don't seem to be affected)...so I don't know if it's really worth to investigate any further...