Project

General

Profile

Actions

Emulator Issues #12174

closed

Port speed limit to new config system

Added by JMC4789 almost 4 years ago. Updated about 2 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-15835

Description

Apparently some games can actually run full speed and users want this now. The only way to currently disable the frame-limiter is to savestate, close the game, turn off the framelimiter, reload the game, load the savestate.

Actions #1

Updated by JosJuice almost 4 years ago

  • Operating system Android added
  • Operating system deleted (N/A)
Actions #2

Updated by ryanebola16 almost 4 years ago

  • Status changed from New to Accepted
Actions #3

Updated by ryanebola16 almost 4 years ago

  • Status changed from Accepted to Fix pending
Actions #4

Updated by ryanebola16 almost 4 years ago

  • Status changed from Fix pending to Work started

Oops, misread the in-game part.

Actions #5

Updated by ryanebola16 almost 4 years ago

  • Status changed from Work started to Accepted

Postponed due to plans to convert Speed Limit to a different config system.
See https://github.com/dolphin-emu/dolphin/pull/8928#issuecomment-653865869.

Actions #6

Updated by ryanebola16 almost 4 years ago

  • Status changed from Accepted to Work started

I have this PR written in a way that doesn't bypass the config system. It will require a rewrite when https://github.com/dolphin-emu/dolphin/pull/8858 is merged so I'll submit it when those are merged.

Actions #7

Updated by ryanebola16 almost 4 years ago

  • Status changed from Work started to Fix pending

The merge conflicts are now minor so I might as well submit the PR. https://github.com/dolphin-emu/dolphin/pull/8961

Actions #8

Updated by ryanebola16 over 3 years ago

  • Subject changed from Add Disable Frame-Limiter to In-Game drop down Menu in Android to Port speed limit to new config system
  • Status changed from Fix pending to Accepted
  • Operating system N/A added
  • Operating system deleted (Android)

This setting is now portable to the new config system so that's the better route to go.

Actions #9

Updated by Billiard26 about 2 months ago

  • Operating system Android added
  • Operating system deleted (N/A)
Actions #10

Updated by Billiard26 about 2 months ago

  • Operating system N/A added
  • Operating system deleted (Android)

I don't really know what's going on in this issue report. It seems to have changed ideas.

Speed limit is in "onion" config.

Is the situation different on Android?

Actions #11

Updated by JosJuice about 2 months ago

  • Status changed from Accepted to Fixed

Speed limit was moved to the new config system after this issue was created. We held off on moving it over because it's a setting that gets read very often, and the new config system hadn't really been optimized for speed yet at that point.

Actions #12

Updated by JosJuice about 2 months ago

  • Fixed in set to 5.0-15835
Actions

Also available in: Atom PDF