Project

General

Profile

Emulator Issues #12174

Port speed limit to new config system

Added by JMC4789 5 months ago. Updated 2 months ago.

Status:
Accepted
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Apparently some games can actually run full speed and users want this now. The only way to currently disable the frame-limiter is to savestate, close the game, turn off the framelimiter, reload the game, load the savestate.

History

#1 Updated by JosJuice 5 months ago

  • Operating system Android added
  • Operating system deleted (N/A)

#2 Updated by ryanebola16 5 months ago

  • Status changed from New to Accepted

#3 Updated by ryanebola16 5 months ago

  • Status changed from Accepted to Fix pending

#4 Updated by ryanebola16 5 months ago

  • Status changed from Fix pending to Work started

Oops, misread the in-game part.

#5 Updated by ryanebola16 5 months ago

  • Status changed from Work started to Accepted

Postponed due to plans to convert Speed Limit to a different config system.
See https://github.com/dolphin-emu/dolphin/pull/8928#issuecomment-653865869.

#6 Updated by ryanebola16 4 months ago

  • Status changed from Accepted to Work started

I have this PR written in a way that doesn't bypass the config system. It will require a rewrite when https://github.com/dolphin-emu/dolphin/pull/8858 is merged so I'll submit it when those are merged.

#7 Updated by ryanebola16 4 months ago

  • Status changed from Work started to Fix pending

The merge conflicts are now minor so I might as well submit the PR. https://github.com/dolphin-emu/dolphin/pull/8961

#8 Updated by ryanebola16 2 months ago

  • Status changed from Fix pending to Accepted
  • Subject changed from Add Disable Frame-Limiter to In-Game drop down Menu in Android to Port speed limit to new config system
  • Operating system N/A added
  • Operating system deleted (Android)

This setting is now portable to the new config system so that's the better route to go.

Also available in: Atom PDF