Emulator Issues #12183: [Feature Request] Redump verification enhancement - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #12183

closed

[Feature Request] Redump verification enhancement

Added by 13xforever over 4 years ago. Updated about 4 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

% Done:

Operating system:

N/A

Issue type:

Bug

Milestone:

Regression:

Relates to usability:

Relates to performance:

Easy:

Relates to maintainability:

Regression start:

Fixed in:

5.0-12904

Description

Game Name?
Any disc game

Game ID? (right click the game in the game list, Properties, Info tab)

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

What's the problem? Describe what went wrong.
Right now ISO verification match game entry in Redump dat file by the game code, which is not available for every system (e.g. Wii).
The better and more logical approach would be to check if there is a full hash match somewhere in the file (optionally check that all eligible hashes match for the same entry).
This would eliminate the reliance on the code mappings, and simplify the multi-system verification logic.

What steps will reproduce the problem?
Try to verify any Wii disc image with Wii Redump dat file manually put in the cache (Documents\Dolphin Emulator\Cache\Redump\wii.zip).
Notice how Dolphin is failing to match the game.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
Still an issue as of 5.0-12280

Is the issue present in the latest stable version?
Yes

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

What are your PC specifications? (CPU, GPU, Operating System, more)

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Files

wii verification.png (16.8 KB) wii verification.png

13xforever, 07/10/2020 09:11 AM

Actions

Copy link

Updated by JosJuice over 4 years ago

The problem with not using the game code is that Dolphin can't distinguish between the case where you have a dump of a disc that hasn't been added to the datfile yet and the case where you have a bad dump of a disc which is in the datfile. Because of this, I do not want to remove the game code matching logic. I suppose it would be possible to report "good dump" if the disc image matches an entry in the datfile even if the datfile is missing game codes, though... But it would not make the logic simpler, and I would still recommend everyone to use datfiles with game codes.

Game codes being missing from the datfile has nothing to do with GC vs Wii. If you download the datfile using the URL http://redump.org/datfile/wii/serial,version (requires you to be logged in to a Redump account with dumper status, as usual), you'll get the game codes.

Actions

Copy link

Updated by 13xforever over 4 years ago

That is true that you can't guarantee that the dump is bad (at least in the case there were no issues were detected), however matching by code isn't a foolproof guarantee either due to possible disc revisions with the same product code not being present.

In both cases, the chances of this happening for a normal user are ... slim, and people who specialize in rarities know damn well if their dumps are good or not.

Thanks for the link though, I always download whatever default dat file is provided in the download section, so I always forget you can customize it.

Actions

Copy link

Updated by 13xforever over 4 years ago

13xforever wrote:

That is true that you can't guarantee that the dump is bad (at least in the case there were no issues detected), however matching by code isn't a foolproof guarantee either due to possible disc revisions with the same product code not being present.

In both cases, the chances of this happening for a normal user are ... slim, and people who specialize in rarities know damn well if their dumps are good or not.

Thanks for the link though, I always download whatever default dat file is provided in the download section, so I always forget you can customize it.

Actions

Copy link

Updated by JosJuice over 4 years ago

Wait, now that I think about it... how did you manage to bypass the code path that shows the "Serial and/or version data is missing" panic alert and exits with "Failed to parse Redump.org data"? (I added that check in https://dolphin-emu.org/download/dev/0f4c971326ae9389b3ad55b0fefacb708d148f4d/.)

That is true that you can't guarantee that the dump is bad (at least in the case there were no issues were detected), however matching by code isn't a foolproof guarantee either due to possible disc revisions with the same product code not being present.

The code takes the revision into account as well. That is why you need to download http://redump.org/datfile/wii/serial,version and not just http://redump.org/datfile/wii/serial.