Project

General

Profile

Emulator Issues #12417

Netplay does not import a game's TMD before importing its save data

Added by leoetlino 11 days ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

any Wii game

Game ID? (right click the game in the game list, Properties, Info tab)

N/A

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

N/A

What's the problem? Describe what went wrong.

When Wii save syncing is enabled, netplay can import a save without making sure the TMD exists. Our WiiSave code normally enforces the requirement that a game's TMD must exist before save data for that game can be imported by checking if the title data exists. However, the netplay related code in WiiRoot works around that check by creating the title directory manually with incorrect metadata and without importing the TMD:

https://github.com/dolphin-emu/dolphin/blob/84128d95323490464e51a64c6d90fca15bd9af80/Source/Core/Core/WiiRoot.cpp#L317-L320

This naturally causes the system menu to break.

NAND check should also be fixed to report this as a problem rather than merely as a warning that isn't shown to the user.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, 5.0-13653

Is the issue present in the latest stable version?

No (5.0 didn't have Wii save syncing)

Also available in: Atom PDF