Project

General

Profile

Emulator Issues #12429

DSU Controllers Get Broken After Ending Emulation

Added by tunsay 4 days ago. Updated about 15 hours ago.

Status:
Accepted
Priority:
High
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Hello, I have a problem with DSU that I did not have with the others updated (before version 13500 I would say).
Everything is functional when I launch a game, the controller works perfectly, everything is recognized. But as soon as I start to close a game, DSU is no longer usable.

History

#1 Updated by Miksel12 4 days ago

I recently noticed that after closing a game or fifolog for a second time, the log would start spamming: InputCommon\ControllerInterface\DualShockUDPClient\DualShockUDPClient.cpp:240 E[SI]: DualShockUDPClient HotplugThreadFunc send failed
Disabling and enabling the UDPClient doesn't fix it, restarting Dolphin seems to be the only solution. I haven't seen this befor so this seems to be recent regression.

#2 Updated by JMC4789 4 days ago

If someone could figure out when this started, we could try to get it hotfixed.

#3 Updated by Miksel12 4 days ago

5.0-12412 doesn't have the issue and is the latest DSU specific change. Don't have enough time to do more bisecting right now.

#4 Updated by iwubcode 4 days ago

Miksel12 wrote:

5.0-12412 doesn't have the issue and is the latest DSU specific change. Don't have enough time to do more bisecting right now.

Actually 5.0-13430 is the latest targeted change. Haven't done any testing to say if it's the issue though

#5 Updated by Miksel12 4 days ago

5.0-13430 also has no issue.

#6 Updated by Miksel12 4 days ago

I bisected it to 5.0-13461, I double checked as it seems completely unrelated but 5.0-13459 shows no weird behaviour.

#7 Updated by JMC4789 about 17 hours ago

My bisect ended up on 5.0-13430, which makes a lot more sense?

Unsure how you guys got a different bisect.

#8 Updated by JMC4789 about 17 hours ago

  • Regression start set to 5.0-13430
  • Regression changed from No to Yes
  • Priority changed from Normal to High
  • Status changed from New to Accepted
  • Subject changed from Problem witch DSU to DSU Controllers Get Permanently Broken After Ending Emulation Twice

#9 Updated by filoppi about 17 hours ago

It's actually enough to end the emulation once.
This should be fixed in my branch, there was a bunch of bad threads code.
https://github.com/dolphin-emu/dolphin/pull/9489
Unless it was broken after I last merged with master, but you said it was fine before 5.0-13430? Which was my first change to DSU.

#10 Updated by JosJuice about 17 hours ago

  • Subject changed from DSU Controllers Get Permanently Broken After Ending Emulation Twice to DSU Controllers Get Broken After Ending Emulation

Could you split out the fix? That is a very large PR.

#11 Updated by filoppi about 17 hours ago

No this problem doesn't happen neither on 5.0-13430 nor or 5.0-13428 on my machine, but it does happen on current latest. Though not on my build. So it could have been something in between the last time I merged with master that broke it. I will merge and try again as soon as I can, because there were a few fixes I made that could have helped with this.

#12 Updated by JMC4789 about 16 hours ago

I will test again if I have to, but I double checked this bisect because it collided with someone else's bisect.

#13 Updated by JMC4789 about 15 hours ago

  • Regression start deleted (5.0-13430)

Due to inconsistencies with the bug appearing, I'm no longer confident in my bisect. More people seem to be saying it doesn't occur in this build. It may be a race condition unrelated, but I still maintain that it can happen in that build.

Also available in: Atom PDF