Emulator Issues #12434
closed
Dolphin failed to build due to error C1189 with MSVC on windows
0%
Description
Hi All,
Environment:
VS 2019 + Windows Server 2016 + dolphin master branch latest source code.
Dolphin failed to build due to 'fatal error C1189: #error Windows 10.0.19041 SDK or later is required' with MSVC on windows. It can be reproduced on latest commit 9d0983c. Could you please help take a look at this issue? Thanks in advance!
Repro steps:
- git clone https://github.com/dolphin-emu/dolphin.git F:\gitP\dolphin-emu\dolphin
- git submodule init
- git submodule update --recursive
- Open a VS 2019 x64 command prompt and browse to F:\gitP\dolphin-emu\dolphin\Source
- set CL=/D_HAS_DEPRECATED_RESULT_OF=1 /D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING /wd5054
- msbuild /m /p:Platform=x64 /p:Configuration=Release /p:WindowsTargetPlatformVersion=10.0.18362.0 dolphin-emu.sln /t:Dolphin
Actual result:
3>F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.h(18,1): fatal error C1189: #error: Windows 10.0.19041 SDK or later is required [F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.vcxproj]
F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.h(18,1): fatal error C1189: #error Windows 10.0.19041 SDK or later is required [F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.vcxproj]
F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.h(18,1): fatal error C1189: ^ [F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.vcxproj]
Files
Updated by JosJuice about 3 years ago
Not that I know too much about MSVC command-line options, but that you're specifying /p:WindowsTargetPlatformVersion=10.0.18362.0 would prevent it from using 10.0.19041 or later, wouldn't it?
(Relevant pull request, for reference: https://github.com/dolphin-emu/dolphin/pull/9048)
Updated by QuellaZhang about 3 years ago
@JosJuice,Thanks for your info, I've tried the new SDK 10.0.19041.0, it works. So close this ticket.
Thanks,
Lin
Updated by JosJuice about 3 years ago
- Status changed from New to Working as intended