Project

General

Profile

Emulator Issues #12434

Dolphin failed to build due to error C1189 with MSVC on windows

Added by QuellaZhang about 2 months ago. Updated about 2 months ago.

Status:
Working as intended
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Hi All,

Environment:
VS 2019 + Windows Server 2016 + dolphin master branch latest source code.

Dolphin failed to build due to 'fatal error C1189: #error Windows 10.0.19041 SDK or later is required' with MSVC on windows. It can be reproduced on latest commit 9d0983c. Could you please help take a look at this issue? Thanks in advance!

Repro steps:
1. git clone https://github.com/dolphin-emu/dolphin.git F:\gitP\dolphin-emu\dolphin
2. git submodule init
3. git submodule update --recursive
4. Open a VS 2019 x64 command prompt and browse to F:\gitP\dolphin-emu\dolphin\Source
5. set CL=/D_HAS_DEPRECATED_RESULT_OF=1 /D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING /wd5054
6. msbuild /m /p:Platform=x64 /p:Configuration=Release /p:WindowsTargetPlatformVersion=10.0.18362.0 dolphin-emu.sln /t:Dolphin

Actual result:
3>F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.h(18,1): fatal error C1189: #error: Windows 10.0.19041 SDK or later is required [F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.vcxproj]
F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.h(18,1): fatal error C1189: #error Windows 10.0.19041 SDK or later is required [F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.vcxproj]
F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.h(18,1): fatal error C1189: ^ [F:\gitP\dolphin-emu\dolphin\Source\PCH\pch.vcxproj]

dolphin_build.log (193 KB) dolphin_build.log dolphin_build_log QuellaZhang, 02/26/2021 09:46 AM

History

#1 Updated by JosJuice about 2 months ago

Not that I know too much about MSVC command-line options, but that you're specifying /p:WindowsTargetPlatformVersion=10.0.18362.0 would prevent it from using 10.0.19041 or later, wouldn't it?

(Relevant pull request, for reference: https://github.com/dolphin-emu/dolphin/pull/9048)

#2 Updated by QuellaZhang about 2 months ago

@JosJuice,Thanks for your info, I've tried the new SDK 10.0.19041.0, it works. So close this ticket.

Thanks,
Lin

#3 Updated by JosJuice about 2 months ago

  • Status changed from New to Working as intended

Also available in: Atom PDF