Project

General

Profile

Actions

Emulator Issues #12544

closed

Dolphin failed to build due to "fatal error C1083: Cannot open include file: 'FreeSurround/ChannelMaps.h': No such file or directory"

Added by QuellaZhang over 3 years ago. Updated about 3 years ago.

Status:
Working as intended
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Hi All,

Environment:
VS 2019 + Windows Server 2016 + dolphin master branch latest source code.

Dolphin failed to build due to 'fatal error C1083: Cannot open include file: 'FreeSurround/ChannelMaps.h': No such file or directory' with MSVC on windows, all errors come from "Externals" folder. It can be reproduced on latest commit c729852d72f7dcd9877fd4b4a002a0f0d91dcd66. Could you please help take a look at this issue?

Repro steps:

  1. git clone https://github.com/dolphin-emu/dolphin.git F:\gitP\dolphin-emu\dolphin
  2. git submodule init
  3. git submodule update --recursive
  4. Open a VS 2019 x64 command prompt and browse to F:\gitP\dolphin-emu\dolphin\Source
  5. set CL=/D_HAS_DEPRECATED_RESULT_OF=1 /D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING /wd5054
  6. msbuild /m /p:Platform=x64 /p:Configuration=Release /p:WindowsTargetPlatformVersion=10.0.19041.0 dolphin-emu.sln /t:Dolphin

Actual result:
F:\gitP\dolphin-emu\dolphin\Externals\FreeSurround\source\ChannelMaps.cpp(18,1): fatal error C1083: Cannot open include file: 'FreeSurround/ChannelMaps.h': No such file or directory [F:\gitP\dolphin-emu\dolphin\Externals\FreeSurround\FreeSurround.vcxproj]
F:\gitP\dolphin-emu\dolphin\Externals\FreeSurround\source\ChannelMaps.cpp(18,1): fatal error C1083: #include "FreeSurround/ChannelMaps.h" [F:\gitP\dolphin-emu\dolphin\Externals\FreeSurround\FreeSurround.vcxproj]
F:\gitP\dolphin-emu\dolphin\Externals\FreeSurround\source\ChannelMaps.cpp(18,1): fatal error C1083: ^ [F:\gitP\dolphin-emu\dolphin\Externals\FreeSurround\FreeSurround.vcxproj]


Files

build.log (596 KB) build.log QuellaZhang, 06/08/2021 06:54 AM
Actions #1

Updated by Anonymous over 3 years ago

I can't reproduce what you are seeing exactly.

From your build.log, it seems the build steps were actually:

set VSCMD_SKIP_SENDTELEMETRY=1 & "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
set _CL_=/D_HAS_DEPRECATED_RESULT_OF=1 /D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING %_CL_%
cd F:\gitP\dolphin-emu\dolphin\Source
set _CL_=/wd5054 %_CL_%
msbuild /m /p:Platform=x64 /p:Configuration=Release /p:WindowsTargetPlatformVersion=10.0.19041.0 dolphin-emu.sln /t:Dolphin 2>&1

Please try the following:

  1. pull/checkout latest dolphin git commit from master branch and update submodules.
cd F:\gitP\dolphin-emu\dolphin\Source
set VSCMD_SKIP_SENDTELEMETRY=1 & "c:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
msbuild /m /p:Platform=x64 /p:Configuration=Release /p:WindowsTargetPlatformVersion=10.0.19041.0 dolphin-emu.sln /t:Dolphin

(i.e. use vcvarsall)
Please remove the macro overrides from your dolphin build scripts. Those type of issues should be fixed in the main repository (and indeed, they have been for some time).

If the build error you're seeing just started soon before you filed the issue, I wonder if it might be this commit to blame: https://github.com/dolphin-emu/dolphin/pull/9777/commits/d19d2ce2bda16bfca07ace3a3f5b449115ee8fec ? If you still see these build errors, could you try reverting that commit? If that is the problem, any chance you know why your environment is different and/or how to use ExternalIncludePath properly? As you can see, we rely on msbuild setting EXTERNAL_INCLUDE environment variable, which seems to work for everyone else...

Actions #2

Updated by QuellaZhang about 3 years ago

Thanks for the update, verify that Dolphin is clean after removing the macro overrides from the build scripts. This is awesome! Please close this ticket.

Actions #3

Updated by leoetlino about 3 years ago

  • Status changed from New to Working as intended
Actions

Also available in: Atom PDF